Functions also need crash protection

Question

magicus opened this issue 2 years ago · 6 comments

magicus commented 2 years ago

We don't want to bring down the entire InfoBoxOverlay if a single function misbehaves

magicus · Answer 1 · 2022-09-27T14:53:13.000Z

Also, we should consider changing so FunctionManager do not call functions unless we are connected to the Wynncraft server.

kristofbolyai · Answer 2 · 2022-10-18T21:29:02.000Z

Note that #584 only solves the first part; functions are still not guarded by being connected to the wynncraft server.

I forgot that we have the command, and not only overlays. But wait.. Commands are only registered on wynn, same with overlay? Do we need this?

magicus · Answer 3 · 2022-10-18T21:27:52.000Z

Note that #584 only solves the first part; functions are still not guarded by being connected to the wynncraft server.

magicus · Answer 4 · 2022-10-18T21:30:41.000Z

Maybe we don't. It's just a bit of double safety I guess. (In Sweden, there is an expression of "wearing both suspenders and a belt")

kristofbolyai · Answer 5 · 2022-10-18T21:32:23.000Z

IMO if we ever get to call a function while not on wynn, we messed up smth earlier.

magicus · Answer 6 · 2022-10-18T21:46:34.000Z

Ok, I understand that position. Let's go with it.