Guild Objective not self-destructing after completion
IngeniousCoder opened this issue · 10 comments
I don't remember how this looks with just vanilla Wynncraft scoreboard. When you have finished the weekly objectives, does it stay in the scoreboard with like "[6/6]"? Or does it disappear from the scoreboard, maybe after a while?
If it is the latter, maybe we happen to miss the scoreboard update? @kristofbolyai What happens if we get a scoreboard where an entire segment has disappeared. Do we clear out that segment, or can it be that it happens to just hang around indefinitely?
Perhaps we need more robust code to account for the fact that we might miss intermediate updates of the scoreboard (since we're only checking it periodically). An alternative fallback is to listen to the "... has finished their weekly objective" in chat, and clear out the guild objectives explicitly if that is the case.
@IngeniousCoder If you still have this in session, how does it look like if you turn of the Wynntils objective rendering, and only use the vanilla scoreboard?
Perhaps we need more robust code to account for the fact that we might miss intermediate updates of the scoreboard (since we're only checking it periodically). An alternative fallback is to listen to the "... has finished their weekly objective" in chat, and clear out the guild objectives explicitly if that is the case.
Can't we just check when a specific packet is processed, if that isn't done already? Unless that too many packets are sent?
The side would say
Win Dungeons 6/6
Use /guild rewards to claim your rewards
Ideally it should stay at 6/6 and automatically disappear after claimed, but my case it got stuck at 5/6.
Perhaps we need more robust code to account for the fact that we might miss intermediate updates of the scoreboard (since we're only checking it periodically). An alternative fallback is to listen to the "... has finished their weekly objective" in chat, and clear out the guild objectives explicitly if that is the case.
Could we check for "/guild rewards" within the scoreboard?