Every consumer of Wynntils Account Tokens should be able to run asynchronously

Question

Every consumer of Wynntils Account Tokens should be able to run asynchronously

kristofbolyai opened this issue 2 years ago · 2 comments

kristofbolyai commented 2 years ago

See #826 (comment).

magicus · Answer 1 · 2022-12-14T20:48:32.000Z

I think this is best solved by sending out an "We are now logged in"-event.

kristofbolyai · Answer 2 · 2022-12-15T18:07:24.000Z

This same problem causes a weird interaction on WynntilsAccountManager#login. We have to get rid of future#get, because the second api call waits for that. That means that the mod thinks we always fail to set up account, when in reality, it finishes as soon as we stop waiting.

Share to