XercaMod

XercaMod

Mods
160k Downloads

If image has black color mod crashes when I'm trying to add black to pallete (I guess it's #000000)

Closed this issue ยท 1 comments

commented

If image has black color mod crashes when I'm trying to add black to pallete (I guess it's #000000)

xercamods/XercaPaintMod/src/main/java/xerca/xercapaint/common/PaletteUtil.java

Line 100 in 08b3074

int gainFactor = averageMaximum / maximumOfAverage;

Because it tries to divide by zero.

[14:17:35] [Render thread/ERROR] [minecraft/Minecraft]: Unreported exception thrown!
java.lang.ArithmeticException: / by zero
	at xerca.xercapaint.common.PaletteUtil$CustomColor.calculateResult(PaletteUtil.java:100) ~[xercapaint-1.20.1-1.0.1.jar%23418!/:1.20.1-1.0.1] {re:classloading}
	at xerca.xercapaint.common.PaletteUtil$CustomColor.<init>(PaletteUtil.java:86) ~[xercapaint-1.20.1-1.0.1.jar%23418!/:1.20.1-1.0.1] {re:classloading}
	at xerca.xercapaint.common.PaletteUtil.readCustomColorArrayFromNBT(PaletteUtil.java:181) ~[xercapaint-1.20.1-1.0.1.jar%23418!/:1.20.1-1.0.1] {re:classloading}
	at xerca.xercapaint.client.BasePalette.<init>(BasePalette.java:123) ~[xercapaint-1.20.1-1.0.1.jar%23418!/:1.20.1-1.0.1] {re:classloading}
	at xerca.xercapaint.client.GuiCanvasEdit.<init>(GuiCanvasEdit.java:96) ~[xercapaint-1.20.1-1.0.1.jar%23418!/:1.20.1-1.0.1] {re:classloading,pl:runtimedistcleaner:A}
	at xerca.xercapaint.client.ClientStuff.showCanvasGui(ClientStuff.java:65) ~[xercapaint-1.20.1-1.0.1.jar%23418!/:1.20.1-1.0.1] {re:classloading}

After that palette is unusable as it crashes each time when I try to open GUI with it.

Here is example of canvas (in .zip)

painting.paint.zip

commented

this issue should be fixed per #164 being merged