XP Obelisk

XP Obelisk

4M Downloads

[Request] Port to 1.20

Phoupraw opened this issue ยท 18 comments

commented

v1.19.4 can't be directly applied to 1.20.

commented

I'm working on 1.20.
But i have an wierd unresolved bug that corrupt somehow the chunk its placed in when the XP Obelisk got placed.

commented

I'm working on 1.20. But i have an wierd unresolved bug that corrupt somehow the chunk its placed in when the XP Obelisk got placed.

StorageBlockEntity#writeNbt may put null into the compound. Is this possibly a cause?

commented

I checked the NBT data. it*s fine, there's no null.

@Nullable
    @Override
    public Packet<ClientPlayPacketListener> toUpdatePacket() {
        return BlockEntityUpdateS2CPacket.create(this);
    }

causes the chunk to glitch, but without the render will not update.

commented

I'm working on 1.20. But i have an wierd unresolved bug that corrupt somehow the chunk its placed in when the XP Obelisk got placed.

How does it corrupt chunk? I placed obelisk in my world but nothing wrong happened.

commented

Breaking a block leaves ghost blocks behind and the xp_obelisk text does not update when the value changes. If you check the block value with the inspector all values correct. So the render/sync stuff goes bad.

commented

Make StorageBlockEntity#toUpdatePacket return null will fix the corruption, but the hovering text will still not update.

commented

Exactly. that's my current point that i'am struggling with.

commented

Any update on this?

commented

Any update on this?

I am trying rewriting it.

commented

Any update on this?

https://github.com/Phoupraw/XpObelisk/releases/tag/v0.5.0%2B1.20.1

Your repository is marked as private

Oh, sorry. Now it is public.

commented

Any update on this?

https://github.com/Phoupraw/XpObelisk/releases/tag/v0.5.0%2B1.20.1

Your repository is marked as private

commented
commented

Why is this not a fork and doesn't share commit history?

Because it almost doesn't inherit any code.

commented

That's very interesting, maybe I have to do the same thing and try a complete new one.
Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

commented

That's very interesting, maybe I have to do the same thing and try a complete new one. Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

I open it in my repo, as the link above.

I didn't use any new 1.20 network specific stuff. Actually, I just copied code from yours and modified them to pass compile, though the modification is a bit too many. Fortunately it works normally, but therefore I completely have no idea why it doesn't work previously: I didn't change the sync code.

commented

That's very interesting, maybe I have to do the same thing and try a complete new one. Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

I open it in my repo, as the link above.

I didn't use any new 1.20 network specific stuff. Actually, I just copied code from yours and modified them to pass compile, though the modification is a bit too many. Fortunately it works normally, but therefore I completely have no idea why it doesn't work previously: I didn't change the sync code.

Thank you very much. Hopefully I can provide the 1.20 version soon.

commented

That's very interesting, maybe I have to do the same thing and try a complete new one. Is it possible to see how you did it?

Do you use some new 1.20 network specific stuff?

I open it in my repo, as the link above.
I didn't use any new 1.20 network specific stuff. Actually, I just copied code from yours and modified them to pass compile, though the modification is a bit too many. Fortunately it works normally, but therefore I completely have no idea why it doesn't work previously: I didn't change the sync code.

Thank you very much. Hopefully I can provide the 1.20 version soon.

Any news on 1.20.1?