YABBA

YABBA

19M Downloads

Refined Storage External Storage + Yabba Barrel = Weird capacity displayed.

llloyd4 opened this issue · 19 comments

commented

Ok, so, I put an external storage bus on some of my Yabba barrels so the RS network would have access to the contents of those barrels and the capacity displayed oddly, something like 254 / 64 @ over 300% or something like that. So there seems to be a compatibility issue between the two mods. I've updated RS to the latest and already using the latest Yabba.

http://i15.photobucket.com/albums/a395/llloyd4/2017-08-08_01.12.37_zpsflmjtzax.png

refinedmods/refinedstorage#1409

(In case your wondering, I have had compatibility issues boiled down to both mod authors blaming the other so... )

commented

Nah, this one is on me

commented

RS counts the amount of slots * 64, for that display.

commented

So you are saying, and remember I am not a coder so take this with a grain of salt, that Yabba changes the slot maximum amount where, say, Drawers adds slots but limits what can go in to one item?

commented

The calculation RS does is a bit flaky since it doesn't count unstackable items or slot max amounts.

commented

I'm not sure if this is related to the above or not, but I am having a weird issue with AE2 storage buses as well as Refined Storage External Storage with the Anti-barrel. At first it was crashing my AE2 system forcing me to restart the server to recover any time I attempted to withdraw certain items that were being stored in the anti-barrel. I hooked the same barrel up to a small RS system with an External Storage, and the item counts are showing as negative and I am unable to remove any of the items with negative item counts. The items with negative counts include some vanilla items like gold horse armor, as well as RS stack and speed upgrades and empty RS 64k drives, and forestry bees. I also tried piping the items out into a chest with some enderio item conduits, but that doesnt work either.

commented

@raoulvdberge I thought it uses IDeepStorageUnit whenever the TileEntity extends that. Should it use it's getMaxStoredCount()?

commented

IDeepStorageUnit has been deprecated for the StorageDrawers API (IItemRepository).

commented

Wait how I implement those IItemRepository methods without a hard dependency on storagedrawers?

commented

Eh, screw IItemRepository, I will just make Refined Storage integration. It's the only storage mod I personally use anyway

commented
commented

Fixed in 4.1.1. Didn't integrate with RS, instead made an IItemHandler that does very well. Tested a lot with External Storage

commented

Oh, a nice IItemHandler would work good as well obviously :)

commented
commented

Because Refined Storage integrates with Storage Drawers. Maybe if I made an API, RS would integrate with Yabba too <.<
I could always shoot for the stars and make a PR for Forge to add IBarrel or something like that so all mods can use it

commented

Well, if you expose 700 mil slots to RS, it will scan every tick every slot to see if there are changes to process for the storage cache. So a special integration might be a cool thing indeed (you can do so by implementing a IStorageProvider on the tile I believe)

commented

Quick discovery - Refined Storage does not like 700'000'000 items in the barrel.. so I guess I will have to figure out how to do Refined Storage integration after all. Tested with 70'000 and that seems fine. Normally you don't get much more than that

commented

You need to update your API brah. IStorage still has @nullable ItemStacks

commented

Now that I think about it, you probably want external storage to read your inv right? That isn't possible yet with the current API... you could use IStorageProvider but then you would just need to connect an RS cable to the barrel and it would work.. That can't be a thing... I will look into it.

commented