Yet Another World Protector

Yet Another World Protector

247k Downloads

bug: mixin incompatibility with Moonrise-Fabric 0.1.0-beta.4+e244c60

etil2jz opened this issue ยท 6 comments

commented

When using Moonrise with YAWP at the same time, I encountered a mixin injection conflict.
Please see the crash-report attached.

I'm not sure which project to contact first so I priorly came here ๐Ÿ™‚
crash-2024-10-03_10.16.00-server.txt

commented

Thanks for reporting this issue.
Iโ€™ll take a look at it soon.
Best regards

Zordak

commented

Hi again.

As far as I know, there is nothing I could do in this case.

Moonrise is very invasive while optimizing performance there. It does completely overwrite a specific method, which YAWP only injects a little bit of code into to check for the explosion flags.

Unless there is a possibility using mixins to resolve this I fear that is something I can not fix.

What I can say from Moonrise Github Issue Tracker, there a couple of Incompatability Issues with other mods, some with the same Mixin Issue.

commented

Moonrise 0.1.0 beta 5 includes an event for explosions.
This should allow fixing the conflict without a Mixin to Moonrise.
When Moonrise is present you can skip loading the conflicting Mixin with an IMixinConfigPlugin, and instead register a listener for the event.
Tuinity/Moonrise#52
Currently, Modrinth Maven is kind of bugged with file names and won't work for Moonrise, but Curse Maven should work.

commented

@Z0rdak Can you look into it? ๐Ÿ™

commented

Hey there.

Today I learned that something like a IMixinConfigPlugin exists. Thats GREAT! I was looking for something like this to dynamically (config based) load mixins!
Thanks @jpenilla for pointing this out to me.

@etil2jz
I need to finish some other issues first, but I'll look into it.