Crash if Mod Menu is not installed on Fabric

Question

Crash if Mod Menu is not installed on Fabric

jepotter1-archive opened this issue 4 years ago · 4 comments

jepotter1-archive commented 4 years ago

It would be helpful if YUNG's Better Caves were to depend on Mod Menu optionally rather than making it a required dependency since many Fabric users do not use Mod Menu.

jepotter1-archive · Answer 1 · 2021-03-12T19:54:32.000Z

This is likely where the crash originates from:

https://github.com/yungnickyoung/YUNGs-Better-Caves/blob/03f3fb107ea7c116ff8c05060fbc5c8b97518558/src/main/java/com/yungnickyoung/minecraft/bettercaves/config/gui/BCModMenu.java#L5

yungnickyoung · Answer 2 · 2021-05-12T21:49:15.000Z

Fixed in v1.2. Please open a new issue if a problem like this persists.

yungnickyoung · Answer 3 · 2021-04-18T06:34:24.000Z

Yeah, I agree. I regret making this decision when I first ported. It's intended to be an embedded dependency, actually, but I'm guessing ModMenu has updated enough for it to be broken?

Anyway, it will be marked as an optional dependency in the future. I can't give a target date though, I've got a lot of other things on my plate atm.

Tobias36 · Answer 4 · 2021-05-12T11:04:55.000Z

Would also greatly recommend making it an optional dependency, spent some time trying to solve where that crash is comming from. It told me something about Mod Menu and I was confused since I did not even use Mod Menu.

Share to