YUNG's Better Dungeons (Forge)

YUNG's Better Dungeons (Forge)

Mods
65M Downloads

[1.21.1] Crash on rare combination of events

pietro-lopes opened this issue ยท 1 comments

commented

When Skeleton Dungeon and Small Dungeon overlaps just at the exact place where a Jukebox (Skeleton Dungeon side) and a Red Banner (Small Dungeon side) overlaps, it causes a crash.

Seed: -7806792279352025342
place to crash:
tp @s -1232 120 -3648

Crash log: https://mclo.gs/qP8kOcM

This can be fixed setting nbt here to null as this is Air anyway

YUNGs-Better-Dungeons/Common/src/main/java/com/yungnickyoung/minecraft/betterdungeons/world/processor/small_dungeon/SmallDungeonBannerProcessor.java

Line 107 in a86c1a3

return new StructureTemplate.StructureBlockInfo(blockInfoGlobal.pos(), Blocks.CAVE_AIR.defaultBlockState(), blockInfoGlobal.nbt());

YUNGs-Better-Dungeons/Common/src/main/java/com/yungnickyoung/minecraft/betterdungeons/world/processor/small_dungeon/SmallDungeonBannerProcessor.java

Line 112 in a86c1a3

return new StructureTemplate.StructureBlockInfo(blockInfoGlobal.pos(), Blocks.CAVE_AIR.defaultBlockState(), blockInfoGlobal.nbt());

How it generates after the fix:
image

commented

Fixed in v5.1.4.