YUNG's Better Mineshafts (Forge)

YUNG's Better Mineshafts (Forge)

95M Downloads

Aboveground and Underwater Generation

Opened this issue ยท 7 comments

commented

Can you stop mineshafts from generating aboveground and underwater? I've seen this happen in two seeds, though this one at spawn was the only one I was able to find again:

8347598419420470852

commented

Hard to say. It won't be at least for a month, probably.

commented

Yep, this will be addressed. I'm planning on adding biome variants for mineshafts, so oceans will have water variants that are filled with water instead of air.
I'll leave this issue open until this is fixed in case other people want to chime in with ideas and whatnot.

commented

Thanks! Do you have any idea when this might be implemented? I need to decide if I should delay my server release for it.

commented

Good to know, thanks.
I've noticed the above-ground mineshafts only seem to occur in Badlands biomes. For my own purposes, I might just fork this and disable Better Mineshafts in Badlands and ocean biomes if I can.

commented

This is actually intentional, because this is what vanilla mineshafts do. They raise the y-coordinate for badlands so that they break the surface. Of course, this doesn't really work for my mineshafts since the structure is much larger. The code is just still there since I was in a rush to make it for the ModFest and didn't have time to tweak any positioning logic.
In the future I imagine I'll be making the range of possible y-coordinates the same for all biomes (except maybe oceans). If you want to undo the y-coordinate fix for yourself or disable them altogether in some biomes, go for it. It should be pretty easy. Just look around here https://github.com/yungnickyoung/YUNGs-Better-Mineshafts/blob/5bd8e260a7586c6799dc905a046c5094de748d6a/src/main/java/com/yungnickyoung/minecraft/bettermineshafts/FeatureAdder.java#L20 and disable the biome categories you don't want.

commented

Can you tell me how you compile the jar? I use ./gradlew jar but the resulting jar gives Minecraft a startup error: java.lang.ClassNotFoundException: net.minecraft.util.registry.Registry

commented

Try ./gradlew build. The jar will then be in build/libs/