Zenith

Zenith

3M Downloads

Question: Compatibility With Other Mods' Enchantments

maikotui opened this issue ยท 5 comments

commented

I'm running a lot of the RPG Series mods which feature some custom enchantments such as Spell Volatility, Sunfire, etc. I'm just now noticing that the enchantment library is eating these enchantments and they don't show up in the list. Is this expected? I've seen the enchantment library work in other mad packs with enchants from MC Dungeons Armor, but I'm not seeing the RPG series enchants work.

commented

Investigating this, looks like the enchantment is registered in the data for the library, but it doesn't show up in the UI. Investigating code right now.

image
image

commented

Could be an issue on the Spell Power mod side as well. For some reason, I see the "spell_power:magic_protection" enchantment in the UI but not the "spell_power:sunfire" enchant. Both exist in the enchantments.cfg and have the same configuration.

commented

Sorry for the spam, but I figured something out. If I place an item that can take the Sunfire enchantment in the filter slot, it will then show up. Otherwise, it'll be missing. So it's got something to do with net.spell_power.api.enchantment.EnchantmentRestriction. Maybe we're still applying the enchantment restrictions even if the filter is null?

commented

Ah, nice investigating! I'll upload a version with the fix shortly

commented

Should be fixed with 1.1.5