Redirect is so old school (@redirect-induced crash(es) in some mod combination contexts)

Question

Redirect is so old school (@redirect-induced crash(es) in some mod combination contexts)

NerjalNosk opened this issue 2 months ago · 4 comments

NerjalNosk commented 2 months ago

https://github.com/TheWinABagel/Zenith/blob/399d3e3be84a2903f0268c0378ce1d9d6e17dbd5/src/main/java/dev/shadowsoffire/apotheosis/mixin/compat/clean_tooltips/absent/ItemStackMixin.java#L48C4-L48C187

Please use MixinExtras' WrapOperation instead

net.fabricmc.loader.impl.FormattedException: java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_1799 failed
	at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:63) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:482) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.16.5.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) ~[NewLaunch.jar:?]
Caused by: java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_1799 failed
	at net.minecraft.class_5620.method_32211(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_156.method_654(class_156.java:436) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.method_32206(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.<clinit>(class_5620.java:33) ~[client-intermediary.jar:?]
	at net.minecraft.class_5546.<init>(class_5546.java:17) ~[client-intermediary.jar:?]
	at net.minecraft.class_2246.<clinit>(class_2246.java:477) ~[client-intermediary.jar:?]
	at net.minecraft.class_2358.method_10199(class_2358.java:326) ~[client-intermediary.jar:?]
	at net.minecraft.class_2966.method_12851(class_2966.java:54) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:166) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) ~[fabric-loader-0.16.5.jar:?]
	... 5 more
Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_1799 failed
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) ~[fabric-loader-0.16.5.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?]
	at net.minecraft.class_5620.method_32211(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_156.method_654(class_156.java:436) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.method_32206(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.<clinit>(class_5620.java:33) ~[client-intermediary.jar:?]
	at net.minecraft.class_5546.<init>(class_5546.java:17) ~[client-intermediary.jar:?]
	at net.minecraft.class_2246.<clinit>(class_2246.java:477) ~[client-intermediary.jar:?]
	at net.minecraft.class_2358.method_10199(class_2358.java:326) ~[client-intermediary.jar:?]
	at net.minecraft.class_2966.method_12851(class_2966.java:54) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:166) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) ~[fabric-loader-0.16.5.jar:?]
	... 5 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) ~[fabric-loader-0.16.5.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?]
	at net.minecraft.class_5620.method_32211(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_156.method_654(class_156.java:436) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.method_32206(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.<clinit>(class_5620.java:33) ~[client-intermediary.jar:?]
	at net.minecraft.class_5546.<init>(class_5546.java:17) ~[client-intermediary.jar:?]
	at net.minecraft.class_2246.<clinit>(class_2246.java:477) ~[client-intermediary.jar:?]
	at net.minecraft.class_2358.method_10199(class_2358.java:326) ~[client-intermediary.jar:?]
	at net.minecraft.class_2966.method_12851(class_2966.java:54) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:166) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) ~[fabric-loader-0.16.5.jar:?]
	... 5 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector zenith$enchTooltipRewrite(Ljava/util/List;Lnet/minecraft/class_2499;)V in zenith.mixins.json:compat.clean_tooltips.absent.ItemStackMixin from mod zenith failed injection check, (0/1) succeeded. Scanned 0 target(s). Using refmap zenith-refmap.json
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:531) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1490) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:752) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:330) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:246) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:437) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:418) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.15.3+mixin.0.8.7.jar:0.15.3+mixin.0.8.7]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.16.5.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) ~[fabric-loader-0.16.5.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?]
	at net.minecraft.class_5620.method_32211(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_156.method_654(class_156.java:436) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.method_32206(class_5620.java:39) ~[client-intermediary.jar:?]
	at net.minecraft.class_5620.<clinit>(class_5620.java:33) ~[client-intermediary.jar:?]
	at net.minecraft.class_5546.<init>(class_5546.java:17) ~[client-intermediary.jar:?]
	at net.minecraft.class_2246.<clinit>(class_2246.java:477) ~[client-intermediary.jar:?]
	at net.minecraft.class_2358.method_10199(class_2358.java:326) ~[client-intermediary.jar:?]
	at net.minecraft.class_2966.method_12851(class_2966.java:54) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:166) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) ~[fabric-loader-0.16.5.jar:?]

TheWinABagel · Answer 1 · 2024-11-18T00:28:14.000Z

Quite frankly there are a lot of bad mixins in zenith, I had no idea what I was doing when I initially wrote some of them (and have fixed only some of them)
The build system sucks by the way, I really need to start using jitpack or something

NerjalNosk · Answer 2 · 2024-11-18T00:23:00.000Z

Fuck it I'll just PR it myself

NerjalNosk · Answer 3 · 2024-11-17T22:51:56.000Z

Plot twist, I'm dumb, might just be caused by another tooltip mod's tweaking.

However, if they are not already using a redirect, using one yourself here could very well be replaced by a WrapOperation as well.

(I will have to look into my modlist to know what mod, but not rn, likely tomorrow)

NerjalNosk · Answer 4 · 2024-11-18T01:08:04.000Z

Managed with adding mavenLocal() to both Faker & attrib lib's publishing.repositories and running the publish gradle task, less janky and overall more reliable than running publishToMavenLocal

Share to