[1.20.1, Forge] Crash when adding biome features with forge:add_features
Astral-Haze opened this issue ยท 2 comments
This works without zeta, but with zeta it crashes
Mod list:
Zeta 1.0-28
Global Packs 1.16.2_forge
TerraBlender 3.0.1.10 (dependency)
Regions Unexplored 0.5.6
CorgiLib 4.0.3.3 (dependency)
Biomes O' Plenty 19.0.0.95
GlitchCore 0.0.1.1 (dependency)
and a datapack with the modifier at \data\minecraft\forge\biome_modifier\thingy.json
modifier:
{
"type": "forge:add_features",
"biomes": "biomesoplenty:tundra",
"features": [
"regions_unexplored:maple_shrub_mix",
"regions_unexplored:pine_dead_shrub_mix"
],
"step": "vegetal_decoration"
}
Relevant part deobf with Linkie:
java.lang.IllegalStateException: Feature order cycle found, involved sources: [Reference{ResourceKey[minecraft:worldgen/biome / regions_unexplored:fen]=net.minecraft.world.level.biome.Biome@233202aa}, Reference{ResourceKey[minecraft:worldgen/biome / biomesoplenty:tundra]=net.minecraft.world.level.biome.Biome@63dd81ee}]
at net.minecraft.world.level.biome.FeatureSorter.buildFeaturesPerStep(FeatureSorter.java:100) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at net.minecraft.world.level.chunk.ChunkGenerator.lambda$new$2(ChunkGenerator.java:102) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading,re:mixin}
at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:183) ~[guava-31.1-jre.jar%23102!/:?] {}
at net.minecraft.world.level.chunk.ChunkGenerator.applyBiomeDecoration(ChunkGenerator.java:288) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading,re:mixin}
at net.minecraft.world.level.chunk.ChunkStatus.lambda$static$11(ChunkStatus.java:108) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading,pl:accesstransformer:B}
at net.minecraft.world.level.chunk.ChunkStatus$SimpleGenerationTask.doWork(ChunkStatus.java:309) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at net.minecraft.world.level.chunk.ChunkStatus.generate(ChunkStatus.java:252) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading,pl:accesstransformer:B}
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$27(ChunkMap.java:643) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-6.0.8.jar%23107!/:?] {}
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$29(ChunkMap.java:634) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150) ~[?:?] {}
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] {}
at net.minecraft.server.level.ChunkTaskPriorityQueueSorter.lambda$message$1(ChunkTaskPriorityQueueSorter.java:62) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at net.minecraft.util.thread.ProcessorMailbox.pollTask(ProcessorMailbox.java:91) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at net.minecraft.util.thread.ProcessorMailbox.pollUntil(ProcessorMailbox.java:146) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at net.minecraft.util.thread.ProcessorMailbox.run(ProcessorMailbox.java:102) ~[client-1.20.1-20230612.114412-srg.jar%23170!/:?] {re:classloading}
at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) ~[?:?] {}
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {}
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {}
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {}
Ugh, this thing again
This also happens when attempting to add a custom biome. Get the same Feature Cycle Order error. Using Cyanide, it reports this as the problem:
Feature '[Inline feature: Placed Direct{Configured: org.violetmoon.zeta.world.DeferredFeature@6063c5a: net.minecraft.world.level.levelgen.feature.configurations.NoneFeatureConfiguration@14b8b5d5}]'
must be before 'tconstruct:earth_geode' (defined in 'minecraft:windswept_savanna' at index 1, 2 and 263 others)
must be before 'tconstruct:sky_geode' (defined in 'minecraft:windswept_savanna' at index 2, 3 and 245 others)
must be before '[Inline feature: Placed Direct{Configured: org.violetmoon.zeta.world.DeferredFeature@6063c5a: net.minecraft.world.level.levelgen.feature.configurations.NoneFeatureConfiguration@14b8b5d5}]'
When checking the biome json it looks identical to other biomes that seem to work fine, and Zeta seems to be adding in this "None" feature on its own