[1.7.2, 1.1.4] Controls not saved if set via vanilla controls menu
RoyCurtis opened this issue ยท 4 comments
Reproduction
- Go to Options > Controls > Zyin's Hud
- Click any key (e.g. "Animal Info") and set to a different key
- Click "Done", then restart Minecraft
- Go back to Options > Controls > Zyin's Hud
Observe that the new key set in step 2 has reverted back to default. This does not happen if the control is changed via the Zyin's Hud menu instead.
Reported as this has caused confusion with some users.
This is a known bug that's been around for a while now and was posted on the list of known bugs sometime back in 1.6.4. Forge is in charge of handling hotkey registration/saving, but their solution is buggy in that it doesn't save changes that you make when using the Options > Controls menu. To resolve this I made my own solution that will save hotkeys to my config file when using the Zyin's HUD Options menu.
As always Roy, thanks for submitting bug reports on GitHub.
Oops, my bad. Incidentally, I made a similar report for Schematica and was told the same thing but also that it should have been fixed in one of the latest Forge versions. Perhaps it is still wonky. No problem!
This is fixed as of Forge 1040. I tested with the latest Zyin's Hud and no code changes seem to be necessary for vanilla menu set keybindings to be fixed.
Forge did indeed fix their keybinding issue, however I still need to make a code change so that my hotkeys load from Minecraft's keybinding instead of my config file.
You can see this by doing the following:
- Controls > Options > change distance measurer hotkey from K to J
- Zyin's HUD Options ... > see that the hotkey still is being shown as K, even though only J works to activate it