All of Fabric 6 - AOF6

All of Fabric 6 - AOF6

589k Downloads

Buckets left from Ad Astra Fuel have different ID

ShadedPL opened this issue · 6 comments

commented

As the title suggests once you use the bucket that had Ad Astra fuel in it, it has a different ID and does not stack with normal buckets.
image

Very minor issue, those buckets can still be used.

commented

any chance you can get the nbt data of the 2 buckets there to see what the difference is? This is probably an issue with either Ad Astra or the API library it uses Botarium and having more info will help open up an issue on the appropriate place

commented

Hold the bucket and use the command:
/kubejs hand

Send the result here.

commented

NBT data, only difference here is that one has the tag:{} field (the one from Ad Astra)
image
/kubejs hand results look the same:
image

commented

Its getting a blank tag: {} which is a bug that has been happening since AoF5. Is this repeatable? Also this bug can happen to any item, randomly.

commented

well I can consistently repeat it with fueling Ad Astra stuff, like rockets or rovers. The returned bucket always has this blank tag.

commented

Yes I was able to reproduce this by filling the machine with oil, putting an empty bucket to take oil back out, and then placing that oil back it. The resulting empty bucket most times was no longer stackable. Also used a mod to print the stacktrace when the item received the empty tag.

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.class_1799.handler$fmd000$putStackTrace(class_1799.java:10162)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.class_1799.method_7980(class_1799.java:627)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.fabricmc.fabric.api.transfer.v1.item.ItemVariant.toStack(ItemVariant.java:100)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.fabricmc.fabric.api.transfer.v1.item.ItemVariant.toStack(ItemVariant.java:89)

[19:29:39] [Render thread/INFO]: [CHAT]  - earth.terrarium.botarium.fabric.fluid.FabricFluidItemHandler.extractFluid(FabricFluidItemHandler.java:48)

[19:29:39] [Render thread/INFO]: [CHAT]  - earth.terrarium.ad_astra.util.FluidUtils.insertItemFluidToTank(FluidUtils.java:63)

[19:29:39] [Render thread/INFO]: [CHAT]  - earth.terrarium.ad_astra.blocks.machines.entity.FuelRefineryBlockEntity.tick(FuelRefineryBlockEntity.java:77)

[19:29:39] [Render thread/INFO]: [CHAT]  - earth.terrarium.ad_astra.blocks.machines.AbstractMachineBlock.lambda$getTicker$1(AbstractMachineBlock.java:58)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.class_2818$class_5563.method_31703(class_2818.java:660)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.class_2818$class_5564.method_31703(class_2818.java:714)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.class_1937.method_18471(class_1937.java:456)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.class_3218.method_18765(class_3218.java:376)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:875)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.class_3176.method_3813(class_3176.java:289)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:819)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:665)

[19:29:39] [Render thread/INFO]: [CHAT]  - net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257)

[19:29:39] [Render thread/INFO]: [CHAT]  - java.base/java.lang.Thread.run(Thread.java:833)