All the Mods 10 - ATM10

All the Mods 10 - ATM10

6M Downloads

[Recipe Issue]: Something happened between 4.5 and 4.10 to cause a lot of mods to become incompatible, such as enchantment industry.

HelpfulMishk03 opened this issue ยท 20 comments

commented

Modpack Version

4.10

Describe the issue

I expect the few mods that i added to ATM10 4.10 to still be compatible to a certain degree when kubejs isn't screaming at me.

Image Image Image
commented

The pack isnt supposed to cater for your own additions

commented

literally you guys are the worst, ive had your previous developers belittle me because of creativity. I will open the code myself and tear it down and fix it from now on, kube and files. You have literally destroyed the love for ATM I once had, and this will be known. I feel sorry for you all

commented

Last message, When you say it isnt catered to me. It kinda is bud, Im your consumer and so is everyone else. Get the facts straight. While it may not be directly towards me, I speak for a community of people who have no idea who you guys are when speaking about rudeness and helpfulness.

commented

@HelpfulMishk03 those are just recipe errors from the added mods that you should report to them to fix.
Those are harmless to ignore, but should be reported to mod authors.

What @AlmanaX-21 is saying is that we can't support like fix that stuff for you as those mods were not added by us.

Those recipe errors are very common when adding mods that didn't write their recipes properly, you can check the file server_scritps/tweaks/recipe_fix.js for some examples

commented

Understood, Alamana could have said it in a much nicer way. My respect has gone way down with how I have been treated by your team. Something that shouldn't happen, one adult to another. Everything can be solved through words instead of fighting. That's the way I like to keep it. What i was hoping for was insight on this. As i cant get any any other way than to go to the devs or these mods and modpack and say hey, nothing changed on the mods that i added, what changed was your modpack. I don't know how to fix mods that i added, that worked absolutely fine in 4.5 and 4.6, that work in 4.10, but report problems with recipes. I was hoping for some insight and that was it. Advice and thats all. Im a consumer of your modpack and i at least expected some advice. Not a harsh comment of "this isn't catered towards you", number one that's a lie because its catered for consumers and number two it was incredibly rude.

commented

Those errors always existed and now we made it explicit.
If you don't want to see them yoh can delete the file local/kubejs/dev.json

and those will be "gone"

commented

Can you upload file:
local/kubejstweaks/erroring_recipes.md ?

that way we can be more accurate on who to report

commented

No unfortunately I'm not home at this moment but when I get home I can most certainly do that to figure this out. This is a priority for me right now. I appreciate you trying to help me

commented
commented

There are other recipe errors in there i am trying to figure out why exactly they broke from switching from version 4.5 to 4.10. If you could at all, possibly provide me with any insight towards those I would be very grateful man. Its really hard when I have to go between three different mod developers to try and figure out whose problem it actually is. I don't say this to belittle you or anything, I am just stating what i feel

commented

Those errors always existed, but we made now explicit on recent versions so we as packdevelopers can fix it or report.
If we kept it hidden we would never find the broken recipes.

If you don't want that, delete file local/kubejs/dev.json, but remember that fixes nothing.

commented

erroring_recipes.md

Errors detected

Error parsing recipe; Failed to parse either. First: No key fluid_tag; Second: Failed to parse either. First: Not a json array; Second: Unknown registry key;
create_enchantment_industry:mixing/cei_epic_ink_recipe

java.lang.IllegalArgumentException: Error parsing recipe create_enchantment_industry:mixing/cei_epic_ink_recipe: Failed to parse either. First: No key fluid_tag in MapLike[{"type":"fluid_tag","amount":1000,"id":"irons_spellbooks:rare_ink"}]; Second: Failed to parse either. First: Not a json array: {"type":"fluid_tag","amount":1000,"id":"irons_spellbooks:rare_ink"}; Second: Unknown registry key in ResourceKey[minecraft:root / neoforge:ingredient_serializer]: minecraft:fluid_tag

mod/create_wizardry

{
  "neoforge:conditions": [
    {
      "type": "almostunified:conditional",
      "conditions_met": true,
      "original_conditions": [
        {
          "type": "neoforge:mod_loaded",
          "modid": "create_enchantment_industry"
        }
      ]
    }
  ],
  "type": "create:mixing",
  "heat_requirement": "heated",
  "ingredients": [
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:blood_vial"
    },
    {
      "item": "irons_spellbooks:blood_vial"
    },
    {
      "type": "fluid_tag",
      "amount": 6,
      "fluid_tag": "create_enchantment_industry:experience"
    },
    {
      "type": "fluid_tag",
      "amount": 1000,
      "id": "irons_spellbooks:rare_ink"
    }
  ],
  "results": [
    {
      "amount": 750,
      "id": "irons_spellbooks:epic_ink"
    }
  ]
}
create_enchantment_industry:mixing/cei_legendary_ink_recipe

java.lang.IllegalArgumentException: Error parsing recipe create_enchantment_industry:mixing/cei_legendary_ink_recipe: Failed to parse either. First: No key fluid_tag in MapLike[{"type":"fluid_tag","amount":1000,"id":"irons_spellbooks:epic_ink"}]; Second: Failed to parse either. First: Not a json array: {"type":"fluid_tag","amount":1000,"id":"irons_spellbooks:epic_ink"}; Second: Unknown registry key in ResourceKey[minecraft:root / neoforge:ingredient_serializer]: minecraft:fluid_tag

mod/create_wizardry

{
  "neoforge:conditions": [
    {
      "type": "almostunified:conditional",
      "conditions_met": true,
      "original_conditions": [
        {
          "type": "neoforge:mod_loaded",
          "modid": "create_enchantment_industry"
        }
      ]
    }
  ],
  "type": "create:mixing",
  "heat_requirement": "superheated",
  "ingredients": [
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:lightning_bottle"
    },
    {
      "item": "irons_spellbooks:lightning_bottle"
    },
    {
      "type": "fluid_tag",
      "amount": 9,
      "fluid_tag": "create_enchantment_industry:experience"
    },
    {
      "type": "fluid_tag",
      "amount": 1000,
      "id": "irons_spellbooks:epic_ink"
    }
  ],
  "results": [
    {
      "amount": 750,
      "id": "irons_spellbooks:legendary_ink"
    }
  ]
}
create_enchantment_industry:mixing/cei_rare_ink_recipe

java.lang.IllegalArgumentException: Error parsing recipe create_enchantment_industry:mixing/cei_rare_ink_recipe: Failed to parse either. First: No key fluid_tag in MapLike[{"type":"fluid_tag","amount":1000,"id":"irons_spellbooks:uncommon_ink"}]; Second: Failed to parse either. First: Not a json array: {"type":"fluid_tag","amount":1000,"id":"irons_spellbooks:uncommon_ink"}; Second: Unknown registry key in ResourceKey[minecraft:root / neoforge:ingredient_serializer]: minecraft:fluid_tag

mod/create_wizardry

{
  "neoforge:conditions": [
    {
      "type": "almostunified:conditional",
      "conditions_met": true,
      "original_conditions": [
        {
          "type": "neoforge:mod_loaded",
          "modid": "create_enchantment_industry"
        }
      ]
    }
  ],
  "type": "create:mixing",
  "ingredients": [
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "item": "irons_spellbooks:arcane_essence"
    },
    {
      "tag": "c:gems/lapis"
    },
    {
      "tag": "c:gems/lapis"
    },
    {
      "type": "fluid_tag",
      "amount": 3,
      "fluid_tag": "create_enchantment_industry:experience"
    },
    {
      "type": "fluid_tag",
      "amount": 1000,
      "id": "irons_spellbooks:uncommon_ink"
    }
  ],
  "results": [
    {
      "amount": 750,
      "id": "irons_spellbooks:rare_ink"
    }
  ]
}
Error parsing recipe; No key item;
endersdelight:chorus_pie_slice

java.lang.IllegalArgumentException: Error parsing recipe endersdelight:chorus_pie_slice: No key item in MapLike[{"id":"endersdelight:chorus_pie_slice","count":4}]

mod/endersdelight

{
  "type": "farmersdelight:cutting",
  "ingredients": [
    {
      "item": "endersdelight:chorus_pie"
    }
  ],
  "tool": {
    "tag": "forge:tools/knives"
  },
  "result": [
    {
      "id": "endersdelight:chorus_pie_slice",
      "count": 4
    }
  ]
}
Invalid component 'ingredients' (unwrapped_ingredient_list)
corn_delight:cob_pipe

Component 'ingredient' is not allowed to contain empty values!

mod/corn_delight

{
  "type": "minecraft:crafting_shapeless",
  "category": "misc",
  "ingredients": [
    {
      "tag": "c:rods/wood"
    },
    {
      "item": "corn_delight:corncob"
    }
  ],
  "result": {
    "count": 1,
    "id": "corn_delight:cob_pipe"
  }
}
Unknown recipe type
create_bic_bit:compat/extruders/oil_extruding

mod/create_bic_bit

{
  "type": "create_mechanical_extruder:extruding",
  "blockIngredients": {
    "first": {
      "blocks": "create_bic_bit:frying_oil"
    },
    "second": {
      "blocks": "minecraft:lava"
    }
  },
  "result": {
    "id": "create_bic_bit:crystallised_oil"
  }
}

so those mods need to fix their recipes

create_wizardry
endersdelight
corn_delight
create_bic_bit

commented

@HelpfulMishk03
AlmanaX-21 is not on the team, nor associated with our team, however what I can only assume they were meaning to say is that this GitHub is used to help us find issues that we can fix on our end. We have our Discord channel tech support chat open to get help with errors (even caused by added mods) that you can usually use to get an answer either from a member of the team, or by somebody in the community. I am sorry you haven't had the best experience with our team in the past, we hope for that to change in the future :)

commented

I understand, thank you for clarifying that up for me. I do not wish to get on anyone's bad side either, everything should be handled by simply talking. I use GitHub mainly and don't usually use discord. I understand everything you've said, however I feel as though I didn't originally ask for much, all i was originally looking for was an answer as to why this was now prominent in the modpack as it wasn't versions ago. Either way, have a blessed day

commented

I appreciate everything you guys have done for me, @pietro-lopes, @TheBedrockMaster. So thank you, I look forward to seeing the atm10 modpack come to a finish and wish you good luck!

commented

I wasn't even mean... I just didnt want to write a whole message for smth I could convey in a concise way. The team said the same thing with more words.

commented

@AlmanaX-21 Even though your intention wasn't to come across as rude, it did because of the way you said it, the pack isn't catered toward your additions. While that statement was true, it wasn't partially because we are consumers. Without us you guys really don't have much. Given over a million people play the modpack you guys are fine. I'm talking from a technical point. Even then, your answer was not an answer, it come across as a snide remark, what i was looking for was insight, as I'm a consumer, again, and haven't seen this happen before on this modpack. Even now, I'm still trying to maintain a kosher level of communication between you despite this.

commented

Yeah I get your point but the thing is, a lot of mods will break the pack and the team cannot possibly provide support for all the options and often the answer is to remove the mods causing the errors. Although, kubejs errors are mostly harmless when it comes to problems

commented

Hello, I was not aware of the controversy surrounding this bug - the "CEI" recipes are my mistake; and an update for Create: Wizardry will be released soon to fix them. Not sure about the others, however.

commented

@TTZPlayz There is no controversy, just a misunderstanding here.