All the Mods 10 - ATM10

All the Mods 10 - ATM10

166k Downloads

[Crash]: value must be non-negative crash with allthemodium

PikachuGabe opened this issue ยท 4 comments

commented

Possible Fixes

Yes

Modpack Version

0.48

What happened?

A player died with an item on them with a negative durability or max durability(unsure which yet) the attempt at creative a grave causes a "value must be non-negative number" exception and thus crash. Easiest way to test is likely getting an allthemodium pickaxe(as that's what caused a crash on my server) and dying then collecting the grave
Could be collecting a grave with a negative damage and max damage item or just dying with one, I cannot get on my pc to test.
For right now I will see if I can manually patch the version of allthemodium on my server. I would directly report this to allthemodium if there was an issue page for that, but the mod is owned by ATMTeam so this should work.

Crash Log

crash-2024-09-12_20.31.36-server.txt

Latest.Log

2024-09-12-1.log

commented

I tried reporting it to the gravestone mod but they said it was from allthemodium and cannot be fixed by them.

commented

I have found the responsible lines of code but given the closed source nature of the mod i dont believe i can send the code itself here. Once I successfully recompile the mod(as wifi issues have been causing my compiler to die) I will send the recompiled version here so it may be implemented.

commented

Havnt had wifi for a while so theres been no progress. Working on getting wifi back.

commented

finally got wifi back. i cannot get this shit to compile though...
maybe intellij will be better for decompiling it in the first place.

cant get shit to work. screw it, im editing the binary directly

not even that worked