All the Mods 3 - ATM3

All the Mods 3 - ATM3

Modpacks
3M Downloads

OpenBlocks Elevators values were reversed.

nullKomplex opened this issue · 3 comments

commented

This occurred in 5.8. I confirmed with Boomflex that this was indeed not intended. As this was not corrected in 5.9.1 I have decided to post an issue.

Relevant commits:

Nerf: 05d6428#diff-4473d6639a060d1f9f9cd707826b2f0cL148
Wrong value increased after nerf: 2da42dc#diff-4473d6639a060d1f9f9cd707826b2f0c

Relevant lines (for convenience):

https://github.com/AllTheMods/ATM-3/blob/master/overrides/config/openblocks.cfg#L150
https://github.com/AllTheMods/ATM-3/blob/master/overrides/config/openblocks.cfg#L157

For clarification:

maxPassThrough is the amount of solid blocks it's allowed to work through. This number is independent of the maximum amount of distance traveled, and only affects blocks inbetween elevators.

searchDistance is how far apart you can place elevators.

As a side-note/opinion/suggestion (not at all relevant to the issue):

Personally I think 20 was small, but 16 is fairly short. We run 32 on our server.

commented

Intended.

I confirmed it was supposed to be 8 and 8, not the other way round.

Closed.

commented

2/16/18:

[5:14 PM] Boomflex: Yeah it was intentional, but looks like I got the 16 and 8 the wrong way round...
[5:14 PM] Boomflex: @Ordinator Might be worth switching back round dude.
[5:15 PM] Boomflex: In the next update ofc

commented