Performance Regression - ElementalCraft
NachtRaben opened this issue ยท 7 comments
Pre-existing world updated from 0.3.11 to 0.3.15 has noticed a severe drop in TPS moving to this version.
See the provided spark for information. Turned off mob farms, barely any (vanilla) entities in the world. But seems the CapabilityElementStorage is performing some really intense calculations at the start of every server tick causing the server to have subpar performance (~9.5TPS) without any direct influence.
I can abide this as well. I updated to .14 and my server was almot unplayable. We were having just like Nacht here very bad TPS so I decided to go on a witch hunt together with a fellow player and ops.
We found the culprit pretty quickly and just as Nacht says it is ElementalCraft, for some reason it has a "JewelHandler" that loops through entities, including players, possibly checking for if they are using the mods Jewels or Trinkets, the thing is: Nobody on the server had any, or was using any as it was just freshly added from the update yet it was still using a lot of single thread performance on the server.
Like, why does the Jewelhandler take up from 11.5% to 22.5% and more depending on player count? Even though no player as said have any of their jewels, items or even entities near them. As newly generated chunks would be needed to find stuff from the mod.
Here are several spark profiler reports we did while we had ElementalCraft:
https://spark.lucko.me/7bCu7Nouem (two players on the server)
https://spark.lucko.me/6WiXvQxWdF (three players on the server)
And here is the latest spark profiler report after removing ElementalCraft:
https://spark.lucko.me/wjzXGbMGHh
I'm by no means an expert in Minecraft modding nor server hosting, but I'm pretty sure the resources I've allocated to the server should be well enough to run the modpack. If any of the devs need details on the server side, let me know.
We reported this to the dev and another dev sent him a message on how to fix this. Hopefully he can update soon we we don't have to remove the mod.
Disregard, issue takes longer after startup to start showing itself.
We reported this to the dev and another dev sent him a message on how to fix this. Hopefully he can update soon we we don't have to remove the mod.
Seems the version with this fix should be available now as his latest commit involves performance issues with the jewel system
After testing with 0.3.16, max tick times are reduced 10x compared to before patch. Issue appears to be resolved.