All the Mods 9 - ATM9

All the Mods 9 - ATM9

9M Downloads

Rule Breaker doesnt work, and causes lag when used on entities

bryce219 opened this issue ยท 0 comments

commented

While hosting a server, I noticed that the Rule Breaker from Mahou Tsukai wasn't fully working as intended, specifically, the loot I was getting from entities wasn't consistent. Then I noticed it also causes a significant amount of lag when used on entites, and in the server log this exception was being thrown every tick after hitting a zombie:

java.lang.Exception
        at TRANSFORMER/[email protected]/stepsword.mahoutsukai.item.rulebreaker.ProbabilityAlterRandom.m_188503_(ProbabilityAlterRandom.java:30)
        at TRANSFORMER/[email protected]/twilightforest.events.EntityEvents.canSpawnCloudParticles(EntityEvents.java:312)
        at TRANSFORMER/[email protected]/twilightforest.events.EntityEvents.onLivingTickEvent(EntityEvents.java:306)
        at TRANSFORMER/[email protected]/twilightforest.events.__EntityEvents_onLivingTickEvent_LivingTickEvent.invoke(.dynamic)
        at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73)
        at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315)
        at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296)
        at TRANSFORMER/[email protected]/net.minecraftforge.common.ForgeHooks.onLivingTick(ForgeHooks.java:264)
        at TRANSFORMER/[email protected]/net.minecraft.world.entity.LivingEntity.m_8119_(LivingEntity.java:2258)
        at TRANSFORMER/[email protected]/net.minecraft.world.entity.player.Player.m_8119_(Player.java:241)
        at TRANSFORMER/[email protected]/net.minecraft.server.level.ServerPlayer.m_9240_(ServerPlayer.java:467)
        at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl.m_9933_(ServerGamePacketListenerImpl.java:262)
        at TRANSFORMER/[email protected]/net.minecraft.network.Connection.m_129483_(Connection.java:263)
        at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerConnectionListener.m_9721_(ServerConnectionListener.java:142)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:907)
        at TRANSFORMER/[email protected]/net.minecraft.server.dedicated.DedicatedServer.m_5703_(DedicatedServer.java:283)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:814)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:661)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:251)
        at java.base/java.lang.Thread.run(Thread.java:833)

This error is also thrown when using the Rule Breaker on yourself (rightclicking). It stops being thrown as soon as the effect wears off or the entity dies. Also, it's not just a TF-MT incompatibility issue (if at all), as when hitting an IS necromancer this error is thrown every tick instead:

java.lang.Exception
        at TRANSFORMER/[email protected]/stepsword.mahoutsukai.item.rulebreaker.ProbabilityAlterRandom.m_188503_(ProbabilityAlterRandom.java:30)
        at TRANSFORMER/[email protected]/net.minecraft.world.entity.Mob.m_7472_(Mob.java:906)
        at TRANSFORMER/[email protected]/net.minecraft.world.entity.LivingEntity.m_6668_(LivingEntity.java:1369)
        at TRANSFORMER/[email protected]/net.minecraft.world.entity.LivingEntity.m_6667_(LivingEntity.java:1327)
        at TRANSFORMER/[email protected]/net.minecraft.world.entity.LivingEntity.m_6469_(LivingEntity.java:1182)
        at TRANSFORMER/[email protected]/net.minecraft.world.entity.player.Player.m_5706_(Player.java:1139)
        at TRANSFORMER/[email protected]/net.minecraft.server.level.ServerPlayer.m_5706_(ServerPlayer.java:1400)
        at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl$1.m_141994_(ServerGamePacketListenerImpl.java:1489)
        at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ServerboundInteractPacket$1.m_142457_(ServerboundInteractPacket.java:166)
        at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ServerboundInteractPacket.m_179617_(ServerboundInteractPacket.java:66)
        at TRANSFORMER/[email protected]/net.minecraft.server.network.ServerGamePacketListenerImpl.m_6946_(ServerGamePacketListenerImpl.java:1457)
        at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ServerboundInteractPacket.m_5797_(ServerboundInteractPacket.java:53)
        at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ServerboundInteractPacket.m_5797_(ServerboundInteractPacket.java:13)
        at TRANSFORMER/[email protected]/net.minecraft.network.protocol.PacketUtils.m_263899_(PacketUtils.java:22)
        at TRANSFORMER/[email protected]/net.minecraft.server.TickTask.run(TickTask.java:18)
        at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.m_6367_(BlockableEventLoop.java:156)
        at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.m_6367_(ReentrantBlockableEventLoop.java:23)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:770)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_6367_(MinecraftServer.java:161)
        at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.m_7245_(BlockableEventLoop.java:130)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_129961_(MinecraftServer.java:753)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_7245_(MinecraftServer.java:747)
        at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.m_18699_(BlockableEventLoop.java:115)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_130012_(MinecraftServer.java:732)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:665)
        at TRANSFORMER/[email protected]/net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:251)
        at java.base/java.lang.Thread.run(Thread.java:833)

It may just be MT, but as it stands right now the item causes lag and while still performs some functions (consistent enchanting works, consistently spawns tortured souls), the item as a whole doesn't work as intended. (I also tested on singleplayer).