Modpack version:
2.7

Description:
See title.

Steps to reproduce:
Put an infusion crystal into an automatic crafter, put enough essence to break it, server crashes.

So far tested:
Crafter (RfTools) - Crash
Analog/Mechanical Crafter (ExUtils) - Crash
Formulaic Assemblicator (Mek) - Crash
(Simple) Crafter (EIO) - Consumes an entire crystal, crafting only 4 essences; No crash

Expected behavior:
No crash.

This forces the players to manually craft all essences until the master infusion crystal is obtainable.

FIX SUGGESTION 1:
Make the master infusion crystal immiedetely craftable to prevent the crashing. Seed tiers will still be gated by their respective station (TC Infusion, AS Crafting etc.), so there won't be progression skips.

FIX SUGGESTION 2:
Add crafttweaker crystals and replace the originals with them. Since the thermal rod (RF Powder crafting) works fine, I believe it's caused by MA itself.

FIX SUGGESTION 3:
Same as 2, but instead of replacing OGs make them unbreakable.

crash-2021-10-13_07.08.46-server.txt

This is the crashlog of the first crash on our Server before we started testing more crafters in SP (RFTools crafter tier 1)

For now I made all Infusion Crystals "practically unbreakable", giving them 2147483647 durability.

I thought there was a way to make them unbreakable normally... So that they dont' even have durability

Oh there is, I just wasn't looking....

It's in the matc config file.

Made the Infusion Crystals unbreakable in 2.8.0, which temporarely fixes the issue (https://www.curseforge.com/minecraft/modpacks/divine-journey-2/files/3493170). However as we discussed earlier, there is still a crash with a bunch of other items that lose durability when crafting. I need an exact list of these so I can fix them too.

Reading the crash report, the issue comes from the Bewitchment Tool Protection Poppet trying to protect the Mystical Agriculture Crystal from breaking.

Question: Is it always the same crash every time? Please provide a couple more crash reports.

I'm not sure if it's Mystical Agriculture's fault, since this particular crash report doesn't even mention that. So I want to wait with this, because if it's Bewitchment's fault, I want to disable the Tool Protection Poppet instead.

Thank you.

Yeah, literally all of them just say it's the Tool Protection Poppet's fault. So I guess the next question is, did you or anyone else craft/use any Tool Protection Poppets in the same world?

Edit: It's just called Tool Poppets.

crash-2021-10-13_16.17.29-server.txt
This was in a freshly created world, seems to be the poppet here as well
Cyan should have a few more crash logs

RFT Crafter, 1
-//-, 2
-//-, 3

XU Mechanical Crafter, 1
-//-, 2

Mek Formulaic Assembler

Other ones from when I tested which machines crash, 1
-//-, 2
-//-, 3
-//-, 4

All have the poppet in question.

They're used for the primordial pears, so yes.
But all crashes I sent were in a newly generated world, so I doubt having crafted one affects that

Hmm, not sure why this like would pop up then :|
at com.bewitchment.common.handler.PoppetHandler.toolProtection(PoppetHandler.java:170)

Okay, so can you try the following things:

• Make a new instance without Bewitchment but with Mystical Agriculture Tiered Crystals, RFTools, and some other basic mods and test if the bug still happens?
• If not, then it's Bewitchment's fault. Unfortuantely the Bewitchment bug report section has been archived for 1.12.2 though: https://github.com/Um-Mitternacht/Bewitchment/issues
• If it isn't Bewitchment's fault, then can you report it to the Mystical Agriculture Tiered Crystals devs here? https://github.com/Electrolyte220/MysticalAgricultureTieredCrystals/issues

If it IS Bewitchment's fault, then I'll have to do something, for example, make all the Crystals unbreakable, or have the unbreakable one available earlier, etc.

Edit: Even if it's Bewitchment's fault, maybe the Mystical Agriculture Tiered Crystals devs can do something about it. I don't want to make the unbreakable Crystal available for one patch, just to have to disable it for the next, because the bug has been fixed. I hope you understand.

No crashes without Bewitchment

Interesting. And, sorry for asking for too much, but does the crash happen with Bewitchment but with other items that use durability?

I know ContentTweaker works, so that would lead me to the assumption that maybe there IS something wrong with Mystical Agriculture Tiered Crystals.

Nether Quartz Cutting Knife (AE2) also crashed (DJ2 2.6).
crash-2021-10-16_19.31.44-server.txt

Diamond Saw (C&B) did not.
Baykok's Bow (Totemic) didn't either.

I didn't see any other items that have crafting recipes, but I just skimmed through the JEI pages, so I could've missed some.
Either way, the problem is clearly on Bewitchment's side.

Can confirm, just removing the Bewitchment mod and removing the bewitchment references in user_recipes.xml (because it won't start otherwise) in a new 2.7 instance before starting it works, no crash.

Interesting. So some items produce a crash, some do not. But it seems like that it IS Bewitchment's fault. Now there are 2 issues:

• Even if the Tool Poppet isn't present, Bewitchment seems to check for it nonetheless, which is very weird.
• Bewitchment is no longer receiving any support for 1.12.2.

Unless we can convince the Bewitchment devs to look into this regardless, the only option I see is to find all (or most) items that produce a crash, and change them to custom items.

Now the problem with custom ContentTweaker items that take damage in each craft, is that AE2 likes to just eat them up. So I might not wanna change the Cutting Knife because of this.