Divine Journey 2

Divine Journey 2

636k Downloads

IE wires sometimes don't destroyed when breaking the connector first

rapturemain opened this issue ยท 2 comments

commented

Modpack version

2.16.0

Description

IE uses raytracing to create and remove wires. In some configurations it fails if the connector broken first. It happens due to raytracing offsets being zero because of missed connector.

Steps to reproduce

Place powered IE Current Transformer at 883 72 21 (facing north)
Place LV Wire Relay at 874 73 29 (facing west)
Connect both with wire coil (unisolated)
Break LV Wire Relay. Wire will drop and won't be rendered anymore
Try standing on 877 71 25 and 878 71 24. It will hurt you like if a wire was there.

Applying wirecutters on the bugged block with a "phantom" wire drops infinite amount of wire coils

Issue also reproduces on other coordinates, this is the only one I remember

Expected behavior

The wire removed completely

Additional context

Workaround: place both connectors to the same places, connect them with a wire, remove wire first using wirecutters, now it is safe to remove the connectors
Also problem is resolved on server restart

I fixed it here so we can use this build

commented

We cannot use mods that are not on curseforge or its approved 3rd party mod list. As per multiple statements on BluSunrises part, Immersive Engineering will not have another update for 1.12.2. Thus, your fork would need to be on the approved 3rd party list. However, as per Immersive Engineering's License (a custom license requiring Blu's permission to redistribute), since it is not licensed under a license similar in style to MIT/GPL, it cannot go on this list.

As such: thank you for making the fork and changes, but we cannot use your fork in DJ2. This bug will remain for the foreseeable future.
Individuals can, of course, build the mod from your fork and replace the IE jar themselves.

commented

Actually, the license doesn't stop people from injecting into the code, only using it without consent. So realistically I can probably fix the problem through Mixin.