ServerStartLinux.sh hangs on ping inside of check_connection
malcom2073 opened this issue ยท 10 comments
The old version (1.82a) had "ping -c 1" which exited after one success or failure, but this version does not, so it hangs, continuously pinging 8.8.8.8 and never continuing on. The next ping test is also missing -c 1
Adding -c 1 to both commands allows the script to operate as expected. Unsure if you want pull requests without issue tickets first.
I think that'd be overcomplicating the script to be honest. I'd rather forfit Windows-bash support, or remove the connectivity check entirely.
Ah I didn't think about that, ping on windows doesn't like the -c flag. There are some ways to find out from bash if a system is WSL or *nix: microsoft/WSL#4555 and then maybe adjust the flags based on that? None of these seem particularly universally acceptable.
Thanks for the report. I'm not seeing that behaviour, it runs just fine on my PC.
Which OS are you running?
Ah yep, it probably uses ping.exe rather than posix ping. ping.exe exits after 4 pings without any additional command line arguments, whereas any posix based ping will run forever