Advanced Rocketry server crash when loading chunks on custom planets

Question

Advanced Rocketry server crash when loading chunks on custom planets

Firecube247 opened this issue 3 years ago · 37 comments

Firecube247 commented 3 years ago

Modpack Version

1.83

Describe your issue.

When I enter a planet like Stella or Terra Nova and start loading chunks, the server crashes. This does not happen on planets in the solar system like Luna or Neptune. Here is the crash report to this issue: https://pastebin.com/zhHPSFEH

After making a bug report under the Advanced Rocketry GitHub page, I was told to update to a newer version, however this makes the modpack crash during startup. Here is the other crash report to the new issue: https://pastebin.com/NF27MueC

Crash Report

Issue 1: https://pastebin.com/zhHPSFEH // Issue 2: https://pastebin.com/NF27MueC

Latest Log

Too large for pastebin. Will provide if asked for.

Have you modified the modpack?

Yes

User Modifications

I tried updating Advanced Rocketry from version 2.0.0.-250 to 2.0.0.-256.

Did the issue happen in singleplayer or on a server?

Server

pclewisnz · Answer 1 · 2022-02-28T19:11:27.000Z

My guess is that these biomes may be designed well enough for being part of a world but not suitable as an entire planet. The generation must be too taxing on all but the most powerful systems. Mine is decent but not super.

Terra-B-Welch · Answer 2 · 2022-03-01T00:18:59.000Z

Sorry for being a little off topic, but is stella habitable or is it VeryHot like Terra Nova and Proxima B?
I thought it'd be the one breathable atmosphere planet since with the sacred springs biome it has now(despite crashes) it has water and trees.

NielsPilgaard · Answer 3 · 2022-03-01T05:10:26.000Z

I intended Terra Nova and Stella to be habitable, the temperature based on distance to sun thing was added recently. Maybe changing that would actually fix this issue 🤔

voidsong-dragonfly · Answer 4 · 2022-03-01T12:26:04.000Z

As stated upon the linked issue in AR, I think so yes. What I think happens is that I get stuck in an endless loop due to how BoP handles the removal of blockstates from the world when they are hot spring water - possibly due to how it deals with turning things into water/not letting it get moved. (this is why the error is a SOF)

Terra-B-Welch · Answer 5 · 2022-03-01T12:23:07.000Z

So the crash was in fact distance related? Was it possibly BoP hot spring water getting evaporated from the planets being too close to their star and that by making them more distant from their star that they arren't "veryhot" anymore?

Terra-B-Welch · Answer 6 · 2022-03-01T13:12:05.000Z

So it's possible that if the hot spring water didn't evaporate that no crash would happen then?
I still have the E2E test instance, so I will try the 200 distance change myself.

EDIT: As far as I can tell, the planets were still considered VeryHot at 200 distance, but idk if it requires a new world to update.

pclewisnz · Answer 7 · 2022-02-27T04:07:18.000Z

I only just went to another star system in my single player E2E which contains AR 2.0.0.-250 and Vulpes 0.4.2.-83.
I had first issue with Terra Nova. I presumed later it was due to the massive workrate needed for game to generate crags biome.
After I closed my not responding game and reloaded I was spawned in space at altitude and fell to the ground which was actually there. Soon after my rocket landed. I went to Novus and no issue. I went to Stella and this was same as Terra Nova only time I made mistake of using rocket pack to gain height to re-aquire the rocket and entering it with right click. Then I pressed space to descend so it got non responsive again. Third time I reloaded and did nothing but it also went non responsive after I dropped a hundred or so in the altitude (falling I presume as no rocket around me). It looked like I rubber banded back to higher altitude and at that point it went unresponsive. Fourth try I changed game settings to make render distance down form 8 chunks to 2 chunks. This time I fell safely to the surface.
I don't know if it was changing to 2 chunks to give world a chance to generate or if it was my cumulative retries that resulted in enough world for me to fall to. Either way, this note is possibly going to help someone out if they don't have another means to teleport away form their doomed landing...

pclewisnz · Answer 8 · 2022-02-27T04:53:19.000Z

Update: I came back to explore Stella and walked a short distance - probably only to edge of chunk and still with Render distance of 2 chunks but another hang.
I don't believe my system is a potato so I'll have to just stay clear for now as it does take a while to load the modpack.
I think it hangs because game is unresponsive and in task list, Java is not consuming any CPU (and says "not responding". I have 6GB allocated to Java.

Terra-B-Welch · Answer 9 · 2022-02-27T12:14:05.000Z

So I guess the only option is to somehow disable BoP hot spring water? If that's whats causing the crash, if I'm understanding correctly.

(Also I failed to check if Stella had a breathable atmosphere or if it was "VeryHot" like Terra Nova and Proxima B are, not related to the issue, but I was looking around to see if any of the custom planets had a breathable atmosphere as I wanted to build a house on one >.<)

NielsPilgaard · Answer 10 · 2022-02-27T12:17:03.000Z

I think the safest is to change to other biomes tbh :/ I removed the biome constraints in-dev so they'll generate with random biomes based on temperature and atmosphere.

NielsPilgaard · Answer 11 · 2021-11-26T22:26:54.000Z

Thank you for the report, I will investigate the issue.

NielsPilgaard · Answer 12 · 2021-11-26T22:27:39.000Z

Did you also update LibVulpes when you tried updating AR? :)

voidsong-dragonfly · Answer 13 · 2021-11-27T00:31:30.000Z

So, I am going to put this here - I briefly caused this bug due to a thing between BoP fluids and AR, I think - and I cannot remember if it corrupted worlds due to how I had it set up. If it did, the world is borked and you're going to need to delete the chunk/world to fix it.

And, as to pack crashing with updated AR: Yeah, a huge amount changed between 1.7.0-x and 2.0.0-x, that second crash is due to an improperly upgraded LV version.

Firecube247 · Answer 14 · 2021-11-27T00:25:22.000Z

Ah, my bad, I forgot to update that as well. The modpack does start now, however the first issue is still leading to a crash. I'll reopen the thread on the Advanced Rocketry page.

Firecube247 · Answer 15 · 2021-11-27T01:05:35.000Z

I'm not really sure if you implied that I should delete my world in hopes for a fix but I deleted the dimension folders to see if the world generation of the latest version would somehow change anything, however it's still crashing. Anyway, let me know if I can help fix the bug.

voidsong-dragonfly · Answer 16 · 2021-11-27T01:34:01.000Z

I meant World in the code sense of a World object is a dimension, sorry that wasn't clear. Still crashing, hmmmm. I might try this at some point but we've mostly moved on from 1.12 now due to 1.16 taking a huge amount of time. I'll see if I can squeeze this in through the GH web interface and get it to compile.

NielsPilgaard · Answer 17 · 2022-02-03T05:25:33.000Z

Seems there's some block on Stella that Advanced Rocketry's atmosphere checker reeeally hates.

NielsPilgaard · Answer 18 · 2022-02-03T05:33:48.000Z

Would someone mind checking if this happens on Novus or Kepler 0118?

Terra-B-Welch · Answer 19 · 2022-02-02T22:07:59.000Z

I wonder if the issue I ran into is related to this, I attempted to land on Stella on the enigmatica 2 expert server I'm playing on and the entire server died, the server is set up to auto-restart, but it seems I can't log into the server now without triggering another crash.

I cut out the error here, as the actual log is 1.7 million characters long so I dont think it'd even fit on pastebin.
https://pastebin.com/G3ST3HAJ

Pastebin
[21:29:59] [Server thread/INFO]: [Server thread] Server side modded connection e - Pastebin.com
Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

jlfree12 · Answer 20 · 2022-02-02T23:01:17.000Z

I don’t know if its the same issue, but I crashed instantly when I loaded stella for the first time as well. Maybe the issue is with that planet or something to do with the type of BOP biome that is used for it.

Terra-B-Welch · Answer 21 · 2022-02-02T23:26:02.000Z

I do know that the server owner had to restore a backup since I couldn't log into the server without crashing it due to this crash.

Terra-B-Welch · Answer 22 · 2022-02-03T15:53:11.000Z

Ok test on Stella and Terra Nova on the latest AR and Libvulpes build done(builds 257 and 88)

The crash still occurs. (Exact same logs as the ones provided, looks like AR planets really don't like water generation.)

Going to test Novus and Kepler 0118 in both current E2E AR and Libvulpes builds and on latest builds.

Kinda a shame really, I was hoping to land on one of these planets if it had a breathable atmosphere and actually build another house on it, then connect via mekanism teleporter.

Terra-B-Welch · Answer 23 · 2022-02-03T16:14:11.000Z

Just flew around Novus and Kepler 0118, didn't encounter any crashes or other issues.

Terra-B-Welch · Answer 24 · 2022-02-03T13:21:40.000Z

I can check on a singleplayer world(not risking the group owner's server again)

I was going to plan landing on stella and terra nova in the copied test instance(in the creative test world) with advanced rocketry and libvulpes being updated to build 257 and 88 respectively, and see if those versions already fixed this issue. If they have, then I guess we already know the solution.

NielsPilgaard · Answer 25 · 2022-02-03T14:52:58.000Z

That'd be nice 😀

NielsPilgaard · Answer 26 · 2022-02-04T15:09:58.000Z

Would you mind supplying the logs even though they're identical? 😀

Terra-B-Welch · Answer 27 · 2022-02-04T16:39:08.000Z

Heres pastebins for both crash reports, is that good enough?
https://pastebin.com/HcAq1APj
https://pastebin.com/Sp6HD81W

Pastebin
---- Minecraft Crash Report ----WARNING: coremods are present: IELoadingP - Pastebin.com
Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

Arithmion · Answer 28 · 2022-02-10T22:04:14.000Z

Here's the log from my attempts to visit Stella, I can walk around for like 30 seconds before I get hard crashed.
latest.log
.

Zimpari · Answer 29 · 2022-03-21T15:31:58.000Z

So does this mean the world is bricked now?
How to get out of the loop of "landing" from the planet Stella?

voidsong-dragonfly · Answer 30 · 2022-03-21T15:56:13.000Z

World is bricked unless you move planets with hot spring water biomes into the habitable zone

Terra-B-Welch · Answer 31 · 2022-03-21T16:00:24.000Z

World is bricked unless you move planets with hot spring water biomes into the habitable zone

I must ask, do planet stats even update on existing worlds when the planets are modified or does it require a new world?

As I remember setting stella and terra nova's distance to 200 like the fix said, but the atmosphere analyzer in the test world still said "VeryHot"

NielsPilgaard · Answer 32 · 2022-03-21T17:01:22.000Z

I must ask, do planet stats even update on existing worlds when the planets are modified or does it require a new world?

I'm unsure whether you have to delete the planets and let them regenerate, you might have tbh.

voidsong-dragonfly · Answer 33 · 2022-03-21T17:03:19.000Z

Editing the planets of a current world is a little funky, but if you edit the XML and the temp.dat (the second with a NBT editor) it should function just fine, as long as the world is not open at the time, as both are saved on world close.

pclewisnz · Answer 34 · 2022-03-21T18:42:41.000Z

So does this mean the world is bricked now? How to get out of the loop of "landing" from the planet Stella?

Did you see my prior post? I did get out of the loop by setting render distance to minimum. I was able to place a teleporter in one loop before lag set in, then in the next loop I was able to take off in the rocket so I didn't even lose the rocket.
Note, you set render distance before loading the world under Options, Video settings.
Results may vary depending on your hardware I guess.
I'm also glad to see there is a fix - which I tested and indeed the planet is now working after making the changes cited by Silfryi

Terra-B-Welch · Answer 35 · 2022-04-08T12:32:37.000Z

The distance and temp thing works for those who want to edit their existing world to apply the fix, I know I'm slow on the draw but I did eventally end up testing that, and was able to fly around the planets without any crashing, and noticed many pools of hot spring water so I can confirm that it's fixed.

MirrorImageQS · Answer 36 · 2022-10-10T23:12:12.000Z

I was able to recreate this issue on Mercury as well. It's the same StackOverflowError centered around zmaster587.advancedRocketry.atmosphere.AtmosphereHandler.onBlockChange. Crash log indicates it's an issue with water again.

-- Block being updated --
Details:
	Source block type: ID #8 (tile.water // net.minecraft.block.BlockDynamicLiquid // minecraft:flowing_water)
	Block: minecraft:water[level=0]
	Block location: World: (-1563,57,-1522), Chunk: (at 5,3,14 in -98,-96; contains blocks -1568,0,-1536 to -1553,255,-1521), Region: (-4,-3; contains chunks -128,-96 to -97,-65, blocks -2048,0,-1536 to -1537,255,-1025)

This after I updated both Advanced Rocketry and LibVulpes to their most recent versions (2.0.0-13 and 0.4.2-25-universal, both released 5/22/22).

Mercury config is as default:

		<planet name="Mercury" DIMID="101" customIcon="lava">
			<skyColor>0,0,0</skyColor>
			<atmosphereDensity>120</atmosphereDensity>
			<gravitationalMultiplier>38</gravitationalMultiplier>
			<orbitalDistance>40</orbitalDistance>
			<rotationalPeriod>1400000</rotationalPeriod>
		</planet>

Looking at the built planetDef.xml from my world save, I noticed that it decided to add the biome advancedrocketry:marsh alongside the mutated savanna biomes. Editing the planetDefs.xml and temp.dat to remove the marsh biome (and then deleting the existing DIM-101 folder so it regenerates) un-breaks Mercury in a test world for me.

        <planet DIMID="101" customIcon="lava" name="Mercury">
            <isKnown>false</isKnown>
            <fogColor>1.0,1.0,1.0</fogColor>
            <skyColor>0.0,0.0,0.0</skyColor>
            <gravitationalMultiplier>38</gravitationalMultiplier>
            <orbitalDistance>40</orbitalDistance>
            <orbitalTheta>0</orbitalTheta>
            <orbitalPhi>0</orbitalPhi>
            <retrograde>false</retrograde>
            <avgTemperature>476</avgTemperature>
            <rotationalPeriod>1400000</rotationalPeriod>
            <atmosphereDensity>120</atmosphereDensity>
            <generateCraters>false</generateCraters>
            <generateCaves>false</generateCaves>
            <generateVolcanos>false</generateVolcanos>
            <generateStructures>false</generateStructures>
            <generateGeodes>false</generateGeodes>
            <biomeIds>minecraft:mutated_savanna_rock;30,advancedrocketry:marsh;30,minecraft:desert_hills;30,minecraft:mutated_mesa_rock;30,minecraft:mutated_mesa_clear_rock;30</biomeIds>
        </planet>

Having gotten the issue on Stella and Terra Nova as well, I see for those ones that it added advancedrocketry:oceanspires and minecraft:mutated_jungle. I suspect those are the two biomes that were in conflict there, but I solved those ones already by fixing the orbitalDistance to 200 as suggested above. Scanning through the other biomeIds it applied to other planets, none of them jump out with anything suspect to me.

@Silfryi So this might turn back into an Advanced Rocketry issue of why does it think high-temperature planets like these should be getting these very aquatic biomes - if not in principle, then at least when the existence of water causes this crash.

voidsong-dragonfly · Answer 37 · 2022-10-11T11:05:30.000Z

1.12 AR has been out of support for months in lieu of a likely, better rewrite coming down the line. Having completely divested myself of 1.12 AR and having seen my mental health surrounding creating mods improve, I've no desire to come back and ruin it again. If you want this done, you should figure it out yourself, I've no stake in this other than to no longer be pinged.

Share to