Enigmatica 2: Expert Skyblock - E2ES

Enigmatica 2: Expert Skyblock - E2ES

412k Downloads

RFTools powercell overflowing

Opened this issue ยท 6 comments

commented

darwithe commented on Mar 5, 2019, 2:02 PM UTC:

Modpack version
Enigmatica 2 Expert 1.57

Can the issue be reproduced?
Yes

Logs
N/A

Issue
The recent change to the RFTools powercell (Issue #852 ) results in an integer overflow(positive number flips to negative number) in the cell hive with just a handful of Advanced Powercells.

This issue was moved by NillerMedDild from NillerMedDild/Enigmatica2Expert#941.

commented

NillerMedDild commented on Mar 5, 2019, 7:50 PM UTC:

Sorry about that, I didn't think the networks would overflow so easily. What are you hoping to get from this issue?

commented

darwithe commented on Mar 5, 2019, 11:34 PM UTC:

Err a reversion so I don't have to manually do it every update?
Sorry I guess I should have been more clear, this isn't just "Oh no, my power is suddenly negative and needs to recharge before things work again", it's also "My cell hive stopped accepting or distributing power because it thinks it has negative capacity." I suppose technically I could drop down more Adv. Powercells so it loops back around again, but I was getting weird results from my redstone power cutoffs too, and frankly having to constantly watch that I don't accidentally overflow again sounds un-fun.

commented

NillerMedDild commented on Mar 6, 2019, 6:40 AM UTC:

I won't revert the change, the Creative Powercells needed the buff.

What you can do, is reduce the amount of Powercells you have per channel/network to make sure the total power capacity is less than 2147483647RF. I'll report the issue to hopefully get it fixed though.

commented

NillerMedDild commented on Mar 6, 2019, 6:44 AM UTC:

McJtyMods/RFTools#1214

commented

darwithe commented on Mar 6, 2019, 7:37 AM UTC:

That's less than 6 Adv. Powercells per network which is way to low. I did some more testing and it's wierd, sometimes it is constrained, and then suddenly it flips negative and then the network locks up, it's really really inconsistant.

Anyway best solution I've found is to drop 1369: I:advancedFactor back to 4. But buff 1390: I:rfPerTick up to 250000. That results in the same 1mrf/t from a creative cell as the factor 40 does but doesn't risk ruining cell networks. The only downside I can see for this is that it buffs the regular Powercell to the point you no longer need Adv. Powercells as much. But frankly the recipe for Adv. Powercell compared to regular Powercell is so cheap that the effect is fairly minimal.

commented

NillerMedDild commented on Mar 6, 2019, 8:17 AM UTC:

Good point, I'll make the change.