Enigmatica 6 - E6 - 1.16.5

Enigmatica 6 - E6 - 1.16.5

1M Downloads

Thermal Series and Integrated Dynamics Machine/Crafting-Terminal Negative TPS Interaction

ejgibs opened this issue · 13 comments

commented

Modpack version
Enigmatica 6 0.5.6

Describe the bug
Have Integrated Dynamics storage system connected to Thermal Series Induction Smelter for auto crafting of Signalum, etc.. When Induction Smelter is set to auto-input via the IN/OUT face of machine, TPS skyrockets as the machine tries to pull from the crafter, which is not a thing it can do. Easily avoidable by disabling the auto-input. Took a minute to diagnose.

Logs
No crash.

Screenshots
N/A, easily reproduced.

commented

Thanks for the help KingLemming.

(note to self)
We need to check if other in/output methods cause lag with the Integrated Crafting Crafter, and eventually relay to https://github.com/CyclopsMC/IntegratedCrafting/issues

GitHub
Craft stuff in Integrated Dynamics networks. Contribute to CyclopsMC/IntegratedCrafting development by creating an account on GitHub.
commented

Thanks for the report, I relayed it on their discord here: https://discord.com/channels/399037120930512897/434101214548852746/868957048098947073

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
commented

A spark profile would be helpful here to see what is causing it exactly. Just set it up run /spark sampler --timeout 50 and post the output.

commented

If I had to guess (and I am atm), the Crafter iterates over its entire inventory (or returns the entire inventory) and then denies when an extraction request is made on the slot. This would be incorrect behavior on their part.

If the intent is that auto-extract isn't allowed at all, then the block should return as such and not doing so would be an error on their part. (Hint: you won't see TPS lag with a smelter next to a dirt block).

If auto-extract IS allowed by their block but you simply don't have a compatible ingredient (and they have a LOT of slots to check), then what you have already done (disabling) is in fact the correct solution.

commented

I can't reproduce this, could you please provide screenshots of your setup?

commented

These were taken on a server that I play alone on, but issue is present in identical single player world.

commented

I can't reproduce this, could you please provide screenshots of your setup?

Thermal Induction Smelter is receiving power from Integrated Dynamics. Top face set to I/O, with Crafting Terminal on top. When Auto input is disabled, fine TPS. When input enabled, spike TPS.

1
2
3
4
5
6
7

commented

Those screenshots didn't order themselves very well. I tried a video but its too large to upload here.

commented

Since you are here again. Does this require a larger setup?

Also please run /spark sampler --timeout 50 while autoinput is on. This would allow the devs to easily find the problem.

commented

Spark without issue: https://spark.lucko.me/JYPGvy0lh5
Spark with issue: https://spark.lucko.me/poYqgBcm5c

I will build a separated system in other chunks to see if issue persists without larger system.

spark
spark is a performance profiling plugin/mod for Minecraft clients, servers and proxies.
spark
spark is a performance profiling plugin/mod for Minecraft clients, servers and proxies.
commented

It does seem that this only causes issues when connected to my larger integrated dynamics system which controls my entire base. I cannot replicate it on small scale.

commented

Ah alright, maybe a false alarm then?

commented

I mean the auto-input does still cause the TPS spike. I think (along the lines of what Lemming mentioned) it has something to do with the number and diversity of items that the crafter has access to in my particular setup. It isn't game-ending after I realized what the issue was.