Enigmatica 6 - E6 - 1.16.5

Enigmatica 6 - E6 - 1.16.5

1M Downloads

JEI + Refined Storage should ideally have a "default" item per valid tag

Quezler opened this issue ยท 9 comments

commented

Modpack version

0.5.9

Describe the bug

when you use the + in JEI to create a pattern for rs, you often get the weirdest of items with technically correct tags.

while it would (probably?) work fine in non-exact mode, i still get nightmares of having those patterns in my system,
hence i have a few requesters setup to keep the bellow items in stock, so if i need to make a pattern with one of the weirdified items i can pick a fresh one from rs to override the suggested pattern with before putting it in a crafter.

Screenshots

obsidian & chests:
Screen Shot 2021-08-13 at 20 09 03

sticks:
Screen Shot 2021-08-13 at 20 10 08

gears:
Screen Shot 2021-08-13 at 20 10 51

and worst of all, connecting glass:
Screen Shot 2021-08-13 at 20 11 36

(keep in mind that none of those "suggested" items are even in the rs network at all, let alone ever made on this map)

commented

Did you have anything else with the tags in question in your system at the time?

commented

i suppose, but it doesn't feel like that ever was the issue:

Screen Shot 2021-08-13 at 20 40 56
Screen Shot 2021-08-13 at 20 41 03
Screen Shot 2021-08-13 at 20 41 09
Screen Shot 2021-08-13 at 20 41 14
Screen Shot 2021-08-13 at 20 41 36

but even if i remove (lets say) all the sticks, i still get a borked suggestion when trying to craft a gold pickace pattern:

Screen Shot 2021-08-13 at 20 42 35

commented

I have a PR open for RS with this feature. Don't think it is possible to fix this easily on pack level.

commented
commented

Oh I thought that PR was merged ages ago :P

commented

The PR over at RS GitHub fixing this has been merged... We're just waiting for it to make it to a release... One day! Maybe

commented

This wouldn't be so annoying if it wasn't for the fact that the weird substitutions actually often break the recipes. It seems like the tag used to match the substitutions when making patterns is not always the same as the tag used to match ingredients during crafting. Either that, or the crafters always consider a pattern an exact match even if it was made without that. This usually happens with recipes containing planks. If I don't change the weird wood type it chooses for the pattern to regular oak planks, the RF system won't use the oak planks in the system to craft with (and there are no other kinds of plank in the system).

commented

This is a rather unfortunate sideeffect of how the the wood types translate into different items depending on which wood type you select.

Picking one wood type vs. another or even selecting multiple wood types are all separate recipes, while patterns can only encode a single one. Removing the oak recipe and using the generic recipe for that could potentially help, but I think JEI breaks that idea....

The PR should improve that since it will pick the most common wood type you have to make the recipe. Now we are just waiting for a release ....

commented

This is fixed now, yeah? Should use whatever you have most of in the tag?