Modpack Version

0.5.11

Describe your issue

Most(all?) ore chunks are tagged as valid for Resourceful Bees apiaries. This causes them to be filtered with most blocks in the game when filtering by tags.

i.e. I use a dank for blocks and a sophisticated backpack for ores. When I use the advanced pickup upgrade with the backpack and filter by tags with a chunk in the filter, cobblestone(and most or all junk blocks) gets pulled into the backpack instead of the null.

Using a filter upgrade to then blacklist items such as cobblestone does not seem to work either as they still go into the backpack.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Singleplayer

This would be why….. Team-Resourceful/ResourcefulBees@5804b74

More details would help, but I assume they are using this feature of Sophisticated Backpacks:

This will just match anything that has a matching tag, I think.

Couldn't you simply filter by a different tag? I'm not sure I see the issue here.

Ok for a bit of clarification from the investigation between me and another dev. Either the ore chunks are the item for a block in the code or they’re manually added to the item tag by E6 (could be via a different tag). Bc my checks only check if the block itself can be collided with and then if so it takes that block as an item and puts it into the valid apiary tag.

Sounds like this may be an issue with the default RB's Valid Apiaries tag adding the tag:

https://github.com/Resourceful-Bees/ResourcefulBees/blob/1.16.5/src/main/resources/data/resourcefulbees/tags/items/valid_apiary.json

We may need to just clear the valid_apiaries tag and let the collision based detection do its thing. I'll toy with that later tonight, if you don't get to it first.

GitHub

ResourcefulBees/valid_apiary.json at 1.16.5 · Resourceful-Bees/ResourcefulBees

Contribute to Resourceful-Bees/ResourcefulBees development by creating an account on GitHub.

Was just digging through that right now... Couldn't find anything that would explain it being added and also couldn't remove #forge:chunks from the tag for some reason :(

Let's leave this open - it's worth resolving it.

Edit: If possible of course!

sorry, hit the wrong button, and yes I was referring to the tag filtering on the backpacks, where it just filters for all the tags on an item

I should just wipe our default tag. Not worth an update for just that. So unless dawn screws something up again and puts an update out the wipe will be in our 1.0.0 version. Just make sure when you wipe it on your side set replace to true. I don’t recall if a tag can be empty so might have to toss cobble in as a placeholder. Idk how it’ll react with my injection

TemperedFool should already be aware, but just for posterity, we released an update that strips our default tag down to just the apiary blocks (keeps it from crashing due to removal of files). Our hasCollision check covers probably 95-98% of blocks anyway. Only notable exception is glassential glass blocks - which we have our own substitute for in the way of honey glass.