Enigmatica 6 - E6 - 1.16.5

Enigmatica 6 - E6 - 1.16.5

1M Downloads

Tinkers Construct Materials are added to the wrong namespace

KnightMiner opened this issue ยท 3 comments

commented

Modpack Version

0.5.11

Describe your issue

Enigmatic 6 adds its custom materials to the Tinkers Construct namespace. This causes us as the devs to receive support requests asking how to make the materials when we have no idea as the tooltip is now wrong, which is why I told you not to do it. Yes, the support requests have already started.

In general you should add all datapack contents to your own namespace (not just materials but also recipes) to give a proper trace to the end user where this came from. Only content that should be in the tconstruct namespace is changes to content we add such as tags or materials. For this issue specifically, you should move your materials to your own namespace.


For the sake of documentation, Tinkers will automatically convert the domain ID you give it to a display name by capitalizing words and replacing underscores with spaces, so if you use an ID of enigmatica_6, it will display as "Enigmatica 6". Alternatively, you can define domain.<domain_name>.display_name in your lang file to override the display name to anything you want, in case you want to use something like enigmatica6 as the ID.


For the sake of migrating old users as you already released a version with the wrong namespace, you can define a JSON as follows:

File data/tconstruct/materials/definition/my_material.json

{
  "redirect": [
    {
      "id": "enigmatic_6:my_material"
    }
  ]
}

This will redirect any existing tools using tconstruct:my_material to enigatic_6:my_material. At this time the redirect will not change the tool NBT unless parts are swapped, but in a future build I plan to ensure any tool stat rebuild should make the redirect permeant allowing you to eventually remove these redirects.

Let me know if it ends up not working, you can reach me on your discord.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Both

commented

I think this is already fixed in dev

Parts show they're added by Enigmatica Mod
image

And Fluids show as from KubeJS
image

commented

Good to see its fixed in dev already, I was looking at the master branch. Hopefully you find the information on redirecting materials useful. if you choose to redirect, all you need is the definition file to handle that.

If you choose to not redirect them, tools crafted with the material will not be permanently broken (a part swap will fix the missing material), but its a bit less ideal.

commented

The redirect is very useful, we'll definitely use that, thanks ๐Ÿ‘