Enigmatica 6 - E6 - 1.16.5

Enigmatica 6 - E6 - 1.16.5

1M Downloads

Pretty Pipes fails to accurately calculate how many of an item it can craft when a recipe outputs multiple of an item

Iris-xii opened this issue · 2 comments

commented

Modpack Version

Enigmatica 6 0.5.21+ (commit 047b59f dev branch, expert mode)

Describe your issue.

Pretty Pipes appears to fail to properly calculate how many of an item it can craft when a recipe outputs multiple of an item.
This results in Pretty Pipes believing it can craft more items than it actually can (often leaving stuck crafts on the terminal or junk leftovers in the crafting module inventory)

Small pretty pipes system to replicate this issue:
image

When the crafting card is set to (for the sake of an example) 1 andesite -> 1 cobble, and there's 20 andesite in the system.
image
Ask for the highest amount of cobble you can. It knows to only ask for 20 cobblestone, as expected.

When the crafting card is set to 1 andesite -> 2 cobble (still with 20 andesite in the system)
image
Ask for the highest amount of cobble you can.
image
The pretty pipes system promises to send back 80 cobblestone, rather than the expected 40 (since there's 20 andesite in the system and every andesite can be turned into two cobble, according to the crafting card)

Another example would be setting the recipe to 1 andesite -> 5 cobble, with 20 andesite in the system. It promises 384 (max amount) rather than the expected 100.

Crash Report

N/A

Latest Log

N/A

Have you modified the modpack?

Yes

User Modifications

Disabled Alex's mobs crimson mosquito spawns through config, removed Tips and PackMenu

Did the issue happen in singleplayer or on a server?

Singleplayer

commented

Thank you for the report, I will investigate the issue.

commented

As I have found time to investigate it myself and wasn't particularly hard to replicate and track down, I have relayed it to the Pretty Pipes github.