Modpack Version

0.5.25

Describe your issue.

Playing on expert (commit 1a33a42)

When upgrade 2 PneumaticCraft tanks with fluids inside to a medium tank, the tanks do not get consumed in the craft

Result:

Notice how it only used 1b of the fluid inside. Only tanks without a fluid get consumed. Does not work for medium tanks to large tank. Did not test with Huge tank.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

Yes

User Modifications

Added following mods:

DynamicSurroundings-1.16.5-4.0.5.0
GameMenuModOption-1.16.4-1.8

Did the issue happen in singleplayer or on a server?

Singleplayer

Thank you for the report, I will investigate the issue.

Has the Medium Tank recipe been changed in E6? Because the default recipe won't allow crafting with tanks that aren't empty (specifically, the tank itemstacks must have no NBT):

The default recipe (note use forge:nbt for the tanks):

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    "PSP",
    "ITI",
    "PSP"
  ],
  "key": {
    "P": {
      "tag": "pneumaticcraft:plastic_sheets"
    },
    "S": {
      "type": "forge:nbt",
      "item": "pneumaticcraft:small_tank",
      "count": 1
    },
    "I": {
      "tag": "forge:ingots/gold"
    },
    "T": {
      "item": "pneumaticcraft:pressure_tube"
    }
  },
  "result": {
    "item": "pneumaticcraft:medium_tank"
  }
}

Yep. It has been changed to accept either gold or copper. I'll take a look at what I did wrong in a bit :D

Odd, I'd have thought the replaceInput script that's doing this would have been safe. Looking into options here and checking with Latcord, but so far my tests have all failed.

Might have to simply revert this one, or possibly do it with a straight datapack recipe instead of scripts.