AE2: Matter condenser doesn't get new values
vaxerski opened this issue · 10 comments
Modpack Version
1.23.1
Describe your issue.
The custom AE2 matter condenser values do not seem to propagate properly.
Expert mode.
/config/ae2/common.json does contain
"Condenser": {
"MatterBalls": 64,
"Singularity": 16000
},and:
[12Sep2024 13:31:28.508] [Server thread/INFO] [com.darkere.configswapper.ConfigSwapper/]: Applying configs for expert mode
[12Sep2024 13:31:28.508] [Server thread/INFO] [com.darkere.configswapper.ModeConfig/]: /home/container/config/ae2/common.json is not a .toml config!
[12Sep2024 13:31:28.508] [Server thread/INFO] [com.darkere.configswapper.ModeConfig/]: Using fallback file replacement for /home/container/config/ae2/common.json
However:
- for me, I can see 64 and 16k in EMI for matter balls and singularities.
- server does not agree. Uses 256 and 256k respectively.
- 2 other players reported their EMI shows 256 and 256k
latest.log attached, truncated to when the server fully starts.
Crash Report
No response
Latest Log
https://gist.github.com/vaxerski/4181806f29b28019c5c9461bda367c21
Have you modified the modpack?
No
User Modifications
No response
Did the issue happen in singleplayer or on a server?
Server
Discord Username
vaxry
Thanks for the report.
I've just updated my dev instance and it initially loaded the incorrect configs. This is a known issue due to some timing constraints. AE2 reads their configs before config swapper can swap the file. This results in the server having the original incorrect values loaded in memory, while the config file shows the correct value.
Rebooting the server (full stop and start) should resolve it, and indeed did resolve it in my dev instance. I'm only currently able to test in single player, however, so it is possible there's still an issue with Client/Server configurations. I'll attempt testing that later, but please let us know how a full stop/start does.
I've restarted the server overall many, many times. I don't think I've ever seen the correct values.
Worth noting it runs in docker and IIRC when the server is stopped the entire docker instance is down, so that's that.
I just did some tests with a brand new server in 1.23.1 and a brand new client install of 1.23.1. On first load, both the server and the client have the incorrect values for the Singularities. Restarting the client fixed it just in Single Player, but it still had the issue in the server, even though the values showed correctly on the client. But after completely stopping the server and restarting it, the config changes took place and Singularities need the intended 16k items to craft.
I would review how exactly is it that you are restarting the server.
I do have to ask - why exactly is configswapper unable to do anything here?
Basically what's happening is config swapper is swapping this config in after ae2 already read this value.... So even tho when the server finishes starting the first time it has the right config in the config folder, that value was already read from normal mode's config...
After a restart that config will have already been swapped so unless you were completely reinstalling the pack every restart, ae2 will have the correct config to read from.
The fix will likely be having niller ship this config for expert as we're already doing for EE config for similar reasons
I do have to ask - why exactly is configswapper unable to do anything here?
Afaik config swapper is already performing the swap as early as possible... Idk if this issue is a race condition or if it's 100% guaranteed to present these symptoms tho
Too technical for me. @Darkere would have to respond. I just know that ae2 is reading the config far earlier than the swap can occur.
Oh, I restarted the server like 2 times and now it did work. Back to 16k.
Still, I don't think this should be happening in the first place... Should we keep this open or close it?