Fabulously Optimized

Fabulously Optimized

2M Downloads

Enable MC-26757 fix/remove ToolTipFix

Madis0 opened this issue ยท 22 comments

commented

What config to change

MC-26757 in Debugify

Why should it be changed

One less mod, Bedrock-like behavior

However it behaves a bit differently than the existing mod and may not work well with really long items/lores (which actually shouldn't exist anyway because most users use vanilla lol)

Category

Mod config option

Additional details

commented

I'd really like the modpack to have everything united in Debugify. It is said that it the way of fixing is Bedrock Edition parity, meaning in a different way than ToolTipFix. I have noticed this in the bug tracker of Debugify, which should be considered.
(It could also be a bug that can't be reproduced though)

commented

(Reposted from discord)
We shouldn't replace tooltipfix by the debugify fix because of how it behaves.
This is tooltipfix

While this is debugify

commented

(Reposted from discord) We shouldn't replace tooltipfix by the debugify fix because of how it behaves.

I made a comment about that here (the issue I mentioned above).

commented

@Julienraptor01
My point was that those lores would not be visible in vanilla anyway and the fix should be for assisting vanilla (different window/GUI sizes), not replacing vanilla's limits entirely. But you do still have a point, maybe Debugify could wrap the text even if it fills the whole screen first.

commented

@Julienraptor01 My point was that those lores would not be visible in vanilla anyway and the fix should be for assisting vanilla (different window/GUI sizes), not replacing vanilla's limits entirely. But you do still have a point, maybe Debugify could wrap the text even if it fills the whole screen first.

The problem is that they don't want to wrap because it's not bedrock parity.
This mod or option is here to fix a bug entirely.
Not to simply take the problem to another level.

commented

image
Julien tested this on Bedrock, so Xander was right - this is how Bedrock behaves, therefore Debugify's fix is not enough to replace this mod.

commented

FabricMC/fabric#2283

I highly doubt Fabric would want to do this, but sure, we can see.

commented

I said it in the Discord server too but I think I had to report it also here. It is said by isXander (the developer of Debugify) that the fix will improve in the future. So I think that this issue should be reopened and get the on hold label

commented

I prefer the mod for now.

commented

New screenshots: isXander/Debugify#106 (comment)

I think I'll still keep TooltipFix for now, but I'm open for feedback.

commented

As isXander said, he is trying to avoid text wrapping for 2 reasons (enter the link to read them), sadly. I wish it was implemented though..

commented

Yes, if it actually wraps instead of cutting off, I will consider.

commented

I prefer the mod for now.

Does this mean that if the Debugify fix gets improved in the future, you'll reconsider?

commented

Should be reopened with isXander/Debugify@82341b0

commented

The new commit does not remove the bedrock parity but extends upon it, only wrapping text when even centering it is too long, making this fix even better than tooltipfix.

Like tooltipfix, there are some scenarios where the wrapping does not take place, Debugify modifies all render tooltip methods apart from one. This is a technical limitation to do with Minecraft having different variants of Text. One of which can't be handled. This method is only called in modded scenarios, namely Mod Menu.

Debugify

image

Additionally, the centering is also smart, and stays on screen at all times...

image

Tooltip Fix

image

And tooltip fix never seems to want to move tooltips to the left, where less wrapping can take place...

image

Additionally, I find tooltip fix to be a bit jarring as you can see the text wrapping changing even as you move the mouse just a little bit...

Peek.2022-09-24.19-33.mp4
commented

@isXander Could you add a vid of Debugify's fix just like the tooltipfix vid pls ?

commented

@isXander Could you add a vid of Debugify's fix just like the tooltipfix vid pls ?

Debugify wraps based on screen width, not remaining width, so it doesn't move.

Peek.2022-09-24.20-27.mp4
commented

Now officially released 2.7.1

commented

What is the status of this? Maybe ask Opinionators?

commented

The status is be patient, lmao

But more seriously, I like this new implementation because

  • it doesn't shift around, which was indeed jarring/unnatural
  • it's wide, which reminds the mod/datapack/whatever creator that this is in fact a "patched" display method, not the one you should be aiming for
    • (TooltipFix aims to make it look "nice", and that means those content creators may just suggest that mod and be done with it)
  • not too wide to be uncomfortable
  • matches Bedrock I guess

...so it will be enabled in the next version.

commented

Done on 4.4.0.