Fabulously Optimized

Fabulously Optimized

2M Downloads

MemoryLeakFix

Madis0 opened this issue ยท 7 comments

commented

Mod name

Memory Leak Fix

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/memoryleakfix

Other links

https://modrinth.com/mod/memoryleakfix
https://github.com/fxmorin/memoryLeakFix

What it does

"Fixes multiple memory leaks"

Why should it be in the modpack

Better memory usage for FO, CF API enabled, in MR

Why shouldn't it be in the modpack

Untested

Categories

Performance optimization

Additional details

No response

commented
commented

If it fixes memory usage things, then why not make an issue in FerriteCore?

commented

If it fixes memory usage things, then why not make an issue in FerriteCore?

The same was asked here and there is no clear answer: https://www.curseforge.com/minecraft/mc-mods/memoryleakfix?comment=5

My guess is that the dev just wanted to create a quick fix without necessarily relying on a different mod. In terms of FO, I'm fine with either a separate or combined mod, so feel free to make an issue there.

commented

Feel free to make an issue there.

I did :) (malte0811/FerriteCore#76)

commented

That's not how this works xDDD
It does not fit into FerriteCore. Ferrite optimizes the way that operations are done for internal structures. The memory leak fix does not do anything related to this.

You guys really need to stop mod merging, it's terrible. I want to continue updating the memory leak fix, and having it be in another mod makes that harder and removes my credit for the amount of work I put into profiling the game and making a fix.

Having multiple mods does not impact performance, I have more to say (not directed at this modpack tho, you can check my gist for that)
I clearly stated that whether it is in Ferrite or not will not change its compatibility with other mods

commented

You guys really need to stop mod merging, it's terrible. I want to continue updating the memory leak fix, and having it be in another mod makes that harder and removes my credit for the amount of work I put into profiling the game and making a fix.

As you said, I understand that your mod is out of scope for FerriteCore and you want to maintain it yourself, so we don't have to discuss this further here.

Edit: removed half of the response to discuss this in your gist instead of here.

commented

Added in 3.9.0