Fabulously Optimized

Fabulously Optimized

2M Downloads

MoreCulling

Madis0 opened this issue ยท 21 comments

commented

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/moreculling

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/moreculling

Source/other link

https://github.com/fxmorin/moreculling

What it does

Culls various non-full blocks

Why should it be in the modpack

Culling does help performance, as evident by Sodium, Entity Culling, Cull Less Leaves etc

Why shouldn't it be in the modpack

  • Performance boosts are not proven yet (tests are inconclusive)
  • CIT is broken in item frames
  • Several mods have incompatibilities

Categories

Performance optimization

Additional details

No response

commented

Vouch. Though note at the current moment this crashes with CullLessLeaves. A fix is being worked on.

commented

I just did some testing and I did indeed had an incredible boost in performance, with over 800 FPS with 32 render distance, when before I had about 200-300

commented

I had a crash caused by this More Culling. Seems to be a conflict with Iris.

commented

I had a crash caused by this More Culling. Seems to be a conflict with Iris.

Alright, you can report it to the mod dev. Overall there is no reason to report bugs here yet as the mod is in alpha (and the label here is WIP). When that changes, I'll actually consider adding it and will care about any potential bugs.

commented

The CF upload exist and is going to be fixed, because it's not working at the moment. (See also FxMorin/MoreCulling#19 (comment))

commented

Officially no longer in Alpha. https://modrinth.com/mod/moreculling/version/v0.4.0
Has automated curseforge releases. Also drastically culls item frames now xD
CullLessLeaves also already has a partial fix, some further fixing is required

commented

Works with Cull Leaves as far as I've noticed (predecessor of CullLessLeaves)

commented

Works with Cull Leaves as far as I've noticed (predecessor of CullLessLeaves)

Yeah this is known, Cull Leaves works but CullLessLeaves doesn't (it's gonna be fixed soon though).

commented

As you said, v.0.5.2 fixed it (see FxMorin/MoreCulling@73fc5dd)

commented

Does not crash with CullLessLeaves as of isXander/CullLessLeaves@55112fc (the new version of CullLessLeaves is unreleased though).

commented

Also Sodium Configuration is now a thing in MoreCulling

commented

Compat version of CLL released

commented

LambdaBetterGrass seems to be unsupported (see FxMorin/MoreCulling#31 (comment))

commented

LambdaBetterGrass seems to be unsupported (see fxmorin/MoreCulling#31 (comment))

Yeah, but it says it won't crash and some optimizations are supported. Please test the mod with FO to see if there are any more conflicts.

commented

For people who say performance doesn't improve: you aren't in an environment where it is improved. It culls things like bamboo, item frames, chorus fruit etc. You have to test in jungles or end islands.

commented

People are currently seeing inconsistent results and after talking with the dev, the issue is likely due to LambdaBetterGrass not being supported yet. Postponing this for later.

Edit: an update is released that should fix it, so you can continue testing

commented

Performance testing results were inconclusive, some mods had incompatibilities. Decided not to add it for 4.2.0 yet, but keeping an eye on it for the future.

commented

0.10.0 added a separate toggle for mods, so at least that could be disabled.

commented

new comment in #424

commented

Updated to 1.19.3!

New Features:

  • Cloud Culling
  • Map Culling (in item frames)

Fixes:
Modded blocks where not correctly being excluded from being culled

Seems worthy of a retry, could replace #512 too.