Remove Cull Less Leaves
Madis0 opened this issue ยท 15 comments
CurseForge link
https://www.curseforge.com/minecraft/mc-mods/cull-less-leaves
CurseForge Mod Distribution
Allowed
Modrinth link
https://modrinth.com/mod/cull-less-leaves
Source/other link
https://github.com/isXander/CullLessLeaves
Mod file size
42.63 KB
What it does
Makes leaves faster without compromising on appearance
Why should it be in the modpack
The implementation might be better-looking and more performant than MoreCulling
Why shouldn't it be in the modpack
MoreCulling seems to obsolete this, while still having fast updates and Sodium integration.
Categories
Performance optimization
Additional details
If obsoleted, the best config for MoreCulling should be decided (it has 3 methods of implementing leaf culling)
Please test #424 (comment)
My results:
https://www.dropbox.com/s/jmxbxhsg9584otb/cll-mc-vanilla%20test.zip?dl=0
F3: https://imgur.com/a/pk7ORQH
Lenovo IdeaPad 520-15IKB
CPU: Intel(R) Core(TM) i5-7200U
GPU: NVIDIA GeForce 940MX
OS: Windows 10
My result: https://imgur.com/a/O306Fh9
Changed Configs: Render distance from 12 to 9
Graphics Card: Intel(R) HD Graphics 610 (Integrated Graphics)
CPU: Intel(R) Pentium(R) CPU 4417U
Memory: 4GB
Were you on quake pro or smth ? There's a lot of distortion
And many have a min value of 0 so yeah seems i can understand your freezing problems
Were you on quake pro or smth ? There's a lot of distortion And many have a min value of 0 so yeah seems i can understand your freezing problems
Yeah, sorry. I forgot to mention that
Pure Performance comparison between CullLessLeaves on 2, MoreCulling Depth 2 and Nothing(vanilla system)
- The point here is to see if CLL and MC use the same options which one is better and Nothing is just here to see if actually these mods are better than disabled
Installing :
- Download a fresh 1.19.1 instance of FO. (Don't add any mods)
- You want to do this to have a clean default config so that we're all on the same base.
- Go to Video settings in the General tab and disable Vsync then go in the Quality tab and disable clouds then go in the Extras tab and enable Show FPS and show coordinates.
- Hit apply.
- Do one of the alternatives.
Alternative 1
- Go then create a world in single player.
- Change the game mode to creative, go to world updates in gamerules and disable advance time of day and put this world seed :
-3678181204597126149. - Generate the world and once you're in do
/time set 6000
Alternative 2
- Download this zipped world folder, unzip it and put it in your saves folder inside of your .minecraft. (the location of the .minecraft vary with your launcher)
Testing (Part1) :
- Once you've done that use this command
/execute in minecraft:overworld run tp @s 57.48 237.36 -391.96 -65.25 90.00. - Do the steps that you'll repeat that i'll only write once
Steps that you'll repeat that i'll only write once
- Now turn around to be sure every chunk is generated and loaded correctly and use the command again.
- Wait a bit for FPS to stabilize and screenshot with F2.
- Now go to Video settings in Performance tab and disable CullLessLeaves then go in the MoreCulling tab, enable Include Mangrove Roots and change leaves culling to Depth.
- Apply go back to game rerun the command to be sure you're in same place, wait for the FPS to stabilize and do a screenshot.
- Now for the last step go back to the video settings in moreculling tab and switch back leaves culling to default and disable include mangrove roots.
- Apply go back in game wait for the FPS to stabilize and screenshot.
- Then go to Video settings in Performance tab and disable CullLessLeaves
Testing (Part2) :
- Do
/execute in minecraft:overworld run tp @s 72.23 110.00 -349.07 3.75 33.60 - Do the steps that you'll repeat that i'll only write once
Testing (Part3) :
- Do
/execute in minecraft:overworld run tp @s -1259.13 231.62 1059.06 197.40 90.00 - Do the steps that you'll repeat that i'll only write once
Testing (Part4) :
- Do
/execute in minecraft:overworld run tp @s -1339.13 119.00 1017.45 -287.85 46.35 - Do the steps that you'll repeat that i'll only write once
Testing (Part5) :
- Do
/execute in minecraft:overworld run tp @s 2353.41 205.01 -746.58 213.76 90.00 - Load chunks and wait like 5mins to make sure leaves are stabilized.
- This is due do an issue in swamps where leaves are too far from trunk and start despawning and cause lag.
- We want here lag to be gone so that testing is coherent.
- Do the steps that you'll repeat that i'll only write once
Testing (Part6) :
- Do
/execute in minecraft:overworld run tp @s 2289.05 87.00 -751.00 -71.54 35.70 - Do the steps that you'll repeat that i'll only write once
Testing (Part7) :
- Do
/execute in minecraft:overworld run tp @s 2873.03 222.13 -2355.33 -750.79 90.00 - Do the steps that you'll repeat that i'll only write once
Testing (Part8) :
- Do
/execute in minecraft:overworld run tp @s 2890.70 139.00 -2311.30 -937.09 49.35 - Do the steps that you'll repeat that i'll only write once
Sending results :
- Now it's time to upload all these screenshots to imgur.
- Put them this description pls otherwise it's useless
Your pics should be in this order with these names :
- CLL Forest Fly
- MC Forest Fly
- Nothing Forest Fly
- CLL Forest Ground
- MC Forest Ground
- Nothing Forest Ground
- CLL Dark Forest Fly
- MC Dark Forest Fly
- Nothing Dark Forest Fly
- CLL Dark Forest Ground
- MC Dark Forest Ground
- Nothing Dark Forest Ground
- CLL Mangrove Fly
- MC Mangrove Fly
- Nothing Mangrove Fly
- CLL Mangrove Ground
- MC Mangrove Ground
- Nothing Mangrove Ground
- CLL Jungle Fly
- MC Jungle Fly
- Nothing Jungle Fly
- CLL Jungle Ground
- MC Jungle Ground
- Nothing Jungle Ground
- Now put as name (replace $username by your username) : CLL 2 vs MC Depth 2 vs Nothing ($username)
- Grab link and paste it here with your specs.
- It should look like that :
Example (actually it's my test)
https://imgur.com/a/xiCEAFv
MSI GE75 Raider 9SE
Intel(R) Core(TM) i7-9750H
NVIDIA GeForce RTX 2060 Mobile
Windows 10
Pure Performance comparison between CullLessLeaves on 2, MoreCulling Depth 2 and Nothing(vanilla system)
The point here is to see if CLL and MC use the same options which one is better and Nothing is just here to see if actually these mods are better than disabled
Improved guide by @wafflecoffee:
https://gist.github.com/wafflecoffee/319973048923c0341ff476ae8948c725
My result :
https://imgur.com/a/xiCEAFv
MSI GE75 Raider 9SE
Intel(R) Core(TM) i7-9750H
NVIDIA GeForce RTX 2060 Mobile
Windows 10
MC seems to be better than Vanilla which seems to be slightly better than CLL
and in addition to that MC seem closer in look to Vanilla while CLL is closer to OptiFine fast leaves
My result: https://imgur.com/a/O306Fh9
Changed Configs: Render distance from 12 to 9 and switched my FOV to Quake Pro
Graphics Card: Intel(R) HD Graphics 610 (Integrated Graphics)
CPU: Intel(R) Pentium(R) CPU 4417U
Memory: 4GB
I'd like to mention that CLL performance heavily depends on Sodium. So make sure to test with FO, not vanilla.
I'd like to mention that CLL performance heavily depends on Sodium. So make sure to test with FO, not vanilla.
Yeah we know and don't test this with vanilla, we test this on FO
Pure Performance comparison between CullLessLeaves on 2, MoreCulling Depth 2 and Nothing(vanilla system)
The point here is to see if CLL and MC use the same options which one is better and Nothing is just here to see if actually these mods are better than disabled
Updated gist
https://gist.github.com/Julienraptor01/8404861d7079222f35ba0646b35cdfdc
Made simpler by not having to switch settings every screenshot.
Test results:
OS: Windows 10
https://www.dropbox.com/s/8t7l46kus1bgu5l/CLL%20MoreCulling%20Tests%20-%20osfanbuff63.zip?dl=0
I'll make a decision based on your tests on Sunday.
Unfortunately I was not able to draw a conclusion yet. Needs more (and maybe different?) testing.
i restested moreculling and cull less leaves and vanilla on hypixel skyblock foraging island
moreculling is still superior to cull less leaves, both on the same mode (depth 2 which the look is different from vanilla)
and also on a moreculling specific mode (check surroundings which look like vanilla and still seem as perfomant than CLL depth 2)
+ moreculling has culling options that cull less leaves doesn't have so from my opinion it should at least be added whitout the leaves culling options
i said at least because i think it should replace CLL
TL;DR
For FPS :
MoreCulling Depth 2 > MoreCulling Check Surroundings > Cull Less Leaves Depth 2 > Vanilla
For vanilla look :
MoreCulling Check Surroundings > Vanilla (same look but less perfomance) > MoreCulling / Cull Less Leaves Depth 2 (not vanilla look-a-like so rejected)