Model Gap Fix
Madis0 opened this issue · 12 comments
CurseForge link
https://www.curseforge.com/minecraft/mc-mods/model-gap-fix
CurseForge Mod Distribution
Allowed
Modrinth link
https://modrinth.com/mod/modelfix
Source/other link
https://github.com/MehVahdJukaar/modefix-multi
Mod file size
29.94 KiB
License
(any other license)
What it does
#47 but better
Why should it be in the modpack
Fixes the same bug without lag, also applies to blocks (while the current mod only applies to items)
Why shouldn't it be in the modpack
Somewhat work in progress
Additional details
No response
Got it. If the license allows forks and redistribution, I don't care which license it is 😄
License is now clear, it's GPL-3.0
And the mod isn't WIP anymore, it's entirely done
Got it. If the license allows forks and redistribution, I don't care which license it is 😄
Yep, i'll try to retest it today or tommorow in case this issue affect FO
MehVahdJukaar/modelfix-multi#2
I'll try most popular resource packs on CF
If some other people can try that too and it doesn't have problems i guess it's ready to be included in FO
The issue above seems to be fixed with the new 1.5 version they uploaded. At least I don't experience it anymore.
Seems like no conclusion yet, one person reported it improved perf and the other that it harmed 🤷
(Apparently) as of version 1.8 of the mod, no gaps can now be seen. Also, if gaps still appear, the is a config now which you can modify to hide the possible gaps.
From Discord (myself):
so i've been long-term testing this for a while, and here's the results:
- certain resourcepacks cause rendering issues, specifically on leaves for me
- doesn't really have a noticeable gain or loss in performance or looks of textures
tl;dr i see no reason to add it at the moment, given it doesn't seem to do much that we don't already have
https://discord.com/channels/859124104644788234/1023944283797065808/1037691495806939227
The 1.4.1 or 1.4.2 update of Iris seems to have fixed all of the rendering issues that I was having, relating to this issue (mainly with Continuity builtins and CITs in combination for some reason), and from my experience it does improve the look of some resourcepacks, especially with 3D ones:
Vanilla:
With Model Gap Fix:
That's normal, the cause of the issue was an optimisation made by the dev of continuity (which contribute to iris too) that had unintended side-effects
The more texture you had, the more the problem was likely to happen
The 1.4.1 or 1.4.2 update of Iris seems to have fixed all of the rendering issues that I was having, relating to this issue (mainly with Continuity builtins and CITs in combination for some reason), and from my experience it does improve the look of some resourcepacks, especially with 3D ones:
Vanilla:
With Model Gap Fix:
it work perfectly by default, is better because it also fix blocks and even seem to improve performance by a small bit
only downside is that there isn't a config GUI if for some people editing the config was needed