Fabulously Optimized

Fabulously Optimized

2M Downloads

Better Advancements

zumbiepig opened this issue ยท 12 comments

commented

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/better-advancements

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/better-advancements

Source/other link

https://github.com/way2muchnoise/BetterAdvancements

Mod file size

71.62 KiB

License

(any other license)

What it does

The mod Better Advancements does the same thing as the AdvancementInfo mod, which is currently included in the modpack.
This mod (Better Advancements) should replace the AdvancementInfo mod because while it does the same thing, the visual aesthetic is a lot better.

Why should it be in the modpack

The mod Better Advancements also has an option to only show the parts of the advancement that you have completed. This keeps it more vanilla-like becuase unless you turn on the setting, it does not tell you what part you need, but only what parts you already have.
For example, if you are trying to get the visit every biome advancement, it won't tell you what biome you need to find, but only what biomes you already visited. (Again, if the player WANTS to show what biome they need, then they may turn in on the the mod settings)
As for the aesthetic part of it listed above, it shows the requirements when you hover over it which looks a lot better, because it looks more built in and looks more like vanilla minecraft.

Why shouldn't it be in the modpack

There are none, as this is a better version of AdvancementInfo, which is currently included in the modpack.

Additional details

The Modrinth link to AdvancementInfo is:
https://modrinth.com/mod/advancementinfo

commented

For some reason, the 1.19+ builds are considered unstable... not sure what's up with that. Otherwise, it could be considered indeed.

commented

I have tested this mod thoroughly myself, and even though they are labeled as beta, they have been fine for me so far with no bugs.
I'd say that if you use the beta builds and don't use the alpha builds, then it should be fine. (That's what I've been doing since 1.19)

commented

Tested, do not interfere with any other feature and provides a more vanilla feeling than advancementinfo

commented

Likely not, as I focus on other changes atm, nor have I actually tested it. Just as long as the issue is open, it is being considered.

commented

Will this be changed in the next version of FO?

commented

Some more info on this mod:
Most modpacks (etc. All The Mods) use Better Advancements.

As for the problem about showing criteria details, this mod has a better vanilla implementation. If you put "criteriaDetail": "Default", "criteriaDetailRequiresShift": true in the config file, then it will not turn off showing what you need to complete an advancement, but you will need to hold down the shift key to view it (This could be in the FO wiki).
Sorry I'm not very good at describing things, so hopefully you understand what I am trying to say.

commented

Yeah, I recently tested it out as well, and noticed that it doesn't respect resource packs (reported to dev).
As for the inclusion overall, I'm currently thinking if even AdvancementInfo is still wanted in FO so I'll ask users to state their opinion on that first, soon.

commented

Im pretty sure EVERYONE appreciates the bigger advancements screen (compared to the tiny one in vanilla minecraft), so something should still be added for that.

commented

But yes, you should ask everyone if they use it to check criteria. Maybe you can do it along with the mod removal vote that's happening in discord.

commented

Just as info, I added the 1.20.1 version in the latest 1.20.2 alpha, and it has been working.

commented

Just as info, I added the 1.20.1 version in the latest 1.20.2 alpha, and it has been working.

In my testing, the game launched but loading a world froze. And I can confirm that important changes were made to the advancement UI code that do imply that none of the mods keep working without changes.

Will see if the dev does implement the resource pack support, but I kind of doubt it would come soon.

commented

#746 was added instead.