Increase DynamicFPS's unfocused FPS
Closed this issue · 5 comments
What config to change
Target Frame Rate for "Unfocused" state in DynamicFPS is currently 1.
Why should it be changed
The target frame rate of 1 means that the window will be flashing the changes once per second, which is very noticable for situations where the window is still visible (side-by-side with another window / multiple screens, instead of fully covered by another window in front of it).
I believe that a more reasonable target FPS value for when the window is still visible would be something like 20.
Unfortunately, it seems like DynamicFPS does not differentiate between a window being unfocused vs being effectively not visible due to being covered by a different window. The "Invisible" settings seem to only apply if the window is minimized to the task bar (GLFW.glfwSetWindowIconifyCallback).
If this were added, something like 20 could be set for "unfocused", and then separate lower settings for "occluded" and "minimized". I'm gonna open a separate issue for this on the relevant repository.
Additional details
Edit by Madis0: For context, vanilla option inactivityFpsLimit sets
- FPS to 30 when AFK for 1 min
- FPS to 10 when AFK for 10 min
- FPS to 10 when minimized.
Thank you for the suggestion!
Currently the frame rate of 1 is there for maximum resource conversion, but I can see the appeal in increasing it.
I will not however change it right now, rather I will have an open conversation about it when FO 6.6.0 9.0.0 gets to beta stage, especially because maybe the mod is no longer needed overall (due to vanilla 1.21.4 or 1.21.5 adding a similar feature).
Personally, I would really appreciate if Dynamic FPS is kept included, because vanilla can't lower the volume when you tab out. That really reminds me of playing Spore, so I like that it's in the pack!
Personally, I would really appreciate if Dynamic FPS is kept included, because vanilla can't lower the volume when you tab out. That really reminds me of playing Spore, so I like that it's in the pack!
That is a very good point, especially because 25w20a just made music play even when paused (with no toggle). Therefore I will focus on the original idea for now, without considering mod removal.
Per discussions and additional research, 9.0.0-beta.2 is now using 30 FPS for background windows by default.