FictionCraft: Atomic Space

FictionCraft: Atomic Space

Modpacks
21.4k Downloads

Wrong item stage for <advancedrocketry:platepress>

lxy-unnamed opened this issue ยท 2 comments

commented

in item_stage.zs, Line 236:

mods.ItemStages.stageModItems("chapter_6", "advancedrocketry");

<advancedrocketry:platepress> is set to stage chapter_6

but it should be stage chapter_2 as set in item_stage.zs, Line 148:

        <advancedrocketry:platepress>
];

for item in itemChp2{
        addItemStage("chapter_2", item);
}

Line 236,237 should be moved up to Line 70

//Chapter 6
var modsChp6 as string[] = [
        "libvulpes",
        "nuclearcraft"
];

for mod in modsChp6{
        mods.ItemStages.stageModItems("chapter_6", mod);
}
commented

It is fixed in the latest version

commented

I'm testing with 1.0.4 alpha, the latest version on curse. AFAIK, this issue was not correctly fixed. Please double check.

I noticed you did this change:

@@ -129,6 +129,9 @@
 	mods.ItemStages.stageModItems("power_elite", mod);
 }
 
+mods.ItemStages.removeItemStage(<advancedrocketry:misc:1>);
+mods.ItemStages.removeItemStage(<advancedrocketry:platepress>);
+
 //Chapter 2
 val itemChp2 as IIngredient[] = [
 	<minecraft:hopper>,
@@ -180,6 +183,4 @@
 mods.ItemStages.removeItemStage(<twilightforest:aurora_pillar>);
 mods.ItemStages.removeItemStage(<thermalfoundation:tool.shears_stone>);
 mods.ItemStages.removeItemStage(<thermalfoundation:tool.shears_wood>);
-mods.ItemStages.removeItemStage(<advancedrocketry:misc:1>);
 mods.ItemStages.removeItemStage(<enderio:item_alloy_endergy_ingot>);
-mods.ItemStages.removeItemStage(<advancedrocketry:platepress>);

But this is NOT a complete fix. You should also do this change:

@@ -62,6 +62,8 @@
 
 //Chapter 6
 var modsChp6 as string[] = [
+	"advancedrocketry",
+        "pneumaticcraft",
 	"libvulpes",
 	"nuclearcraft"
 ];

for mod in modsChp6{
        mods.ItemStages.stageModItems("chapter_6", mod);
}
@@ -233,8 +235,6 @@
 
 mods.ItemStages.addItemStage("chapter_5", <sky_orchards:sapling_osmium>);
 
-mods.ItemStages.stageModItems("chapter_6", "advancedrocketry");
-mods.ItemStages.stageModItems("chapter_6", "pneumaticcraft");
 mods.ItemStages.removeItemStage(<pneumaticcraft:omnidirectional_hopper>);
 mods.ItemStages.removeItemStage(<pneumaticcraft:liquid_hopper>);

Or else <advancedrocketry:platepress> will have two stage, both chapter_2 and chapter_6 because stage chapter_6 is set at line 236 after clearing stage at line 133.
image