GreedyCraft

GreedyCraft

123k Downloads

[BUG] Evolved trait causing major TPS lag

classicduff opened this issue ยท 7 comments

commented

Before reporting, make sure your problem isn't caused by the game running out of RAM and you have read the installation guide carefully.
If the game crashes to your desktop without showing a crash screen it's a RAM issue. Don't submit this kind of issue. Please view the installation guide for how to solve this issue.
If this is not the case check the checkbox below by replacing the space between brackets with an 'x'.

  • Yes, I'm sure this problem isn't because my game ran out of RAM.

Describe the bug
Evolved armor trait causing massive TPS hit, even when not charging, but also had issues when running around with Flux Networks wireless charging on, or sometimes just from the capacitor charging.

To Reproduce
Steps to reproduce the behavior:

  1. Have tinkers armor with evolved trait (I was using Wyvren cores x4), Wyvren 1 upgrades
  2. Take a lot of damage
  3. TPS goes down to 8-10
  4. Take armor off (and have nothing charging it)
  5. TPS goes back to 20

Expected behavior
Minimal tps impact.

Crash reports or logs
Nothing in logs

Details
Please fill out the blanks below:
Modpack Version: ( 3.14.1)
Did you add or remove mods? ( Added lag-goggles )
Did you edit any config or script? ( Turned off mo-bends player animations )
Using shaders? [Write 'Default' if you are using default shader, if you are not using the default shader please write the name of the shader you are using.] ( Default )
Singleplayer, LAN game or server pack? ( Single Player )

Additional context
It even seems to be when the shield recovery bar is recharging that tps issues happen. Immediately fixed when removing armor.

commented

Also the thermal and draconic item chargers will cause tps issues. Botania mana tablets/mirrors too

commented

Armor on and recharging shield recovery
Mean tick time: 130
Mean TPS: 7.6

Take armor off OR shields finished recovering
Mean tick time: 11
Mean TPS: 20

commented

Try not to keep mutliple capacitors in your inventory, I don't think I can fix this easily
Also try to observe if the problem exists without laggoggles, I know that laggoggles is a profiling tool but afaik laggoggles and its dependency can break a lot of things

commented

After a fresh restart the tps hit was significantly less, 20-24 mean tick time, but 20 tps. 8 mean tick time when armor is not recharging.

Definitely still playable when it's like this, but may it get worse the longer you play, I'll do a little more testing today

Edit: Yep, problem came back later on in the session.

commented

After a bit more playing around I can confirm that it happens without lag-goggles. Seems to be fixed by fully restarting the game, but after playing for a while it starts happening again.

It happens when the armor recovery is recharging (not just the RF), and also happens with a weapon that also has the evolved trait.

commented

@TCreopargh might have found something that could help you narrow it down. Having the wireless terminal open completely resolves the TPS issue, but as soon as you close it the TPS goes back to being bad.

Edit: Potential theory - one of the in game info XML mods, or inventory HUD - as these stop being displayed when you open the wireless terminal.

Edit2: Some brief testing looks promising, grinded out a few withers, fought enderman in the end for ~30 minutes, no tps problems so far. I disabled the HUD mod that shows armor %, plus all of the in game info mods. Also just a guess - but maybe something updating the display too often as the shields are recharging? More testing to be done tomorrow.

commented

As mention on discord, this didn't end up solving the issue ๐Ÿ˜”. The TPS issue still goes away when opening the wireless crafting grid though.