GT New Horizons

GT New Horizons

867k Downloads

TX-Loader always fetches minecraft versions

Caedis opened this issue ยท 2 comments

commented

Your GTNH Discord Username

Caedis

Your Pack Version

latest nightly

Your Server

private

Java Version

Java 21

Type of Server

Vanilla Forge

Your Expectation

Currently having some unstable internet and wanted started the pack and hung on loading the TX-Loader coremod for a bit.

The Reality

TXLoader always pulls the latest minecraft version manifests even though this is a 1.7.10 only mod.
When there is no/unstable internet, this can cause increased pack load times.

Your Proposal

Cache the 1.7.10 manifest locally after first pack load, or hard code it as a resource in the mod.
https://piston-meta.mojang.com/v1/packages/ed5d8789ed29872ea2ef1c348302b0c55e3f3468/1.7.10.json

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
commented

Think we decided to just cache all manifests instead of just 1.7.10

commented

I think one of the features of TX-loader is to use assets from modern MC versions without shipping it with your mod. It probably fetches those on purpose, albeit a bit wasteful.