GT New Horizons

GT New Horizons

867k Downloads

Research Completer Stop Requiring a Node when Overclocked to UMV and Above

JustAlkaid opened this issue ยท 1 comments

commented

Your GTNH Discord Username

Alkaid

Your Pack Version

2.6.1

Your Server

Private Server

Java Version

Java 21

Type of Server

Vanilla Forge

Your Expectation

I bulit a Research Completer, but forgot to place nodes into the structure. But I overclocked it to UMV with 2 UIV hatches, then put some research notes in the input bus and start it. What I expected was the machine would stop and void research notes it used.

The Reality

It started and work fine, outputing researched notes.

Your Proposal

Fix this.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
commented

After taking a look at this, it seems to be an issue that when the recipe is umv and above, the multi completes the recipe in 1 tick, and on the first and only call of onRunningTick the machine never subtracts vis from nodes. This also brought to my attention that the vis costs are in general not exact. For example, when running the machine at UEV, the recipe takes 4 ticks to complete and the research that i was using had a vis cost of 15, but since it skips the first tick extracting entirely it only ends up taking 12 total vis from the node.