GT New Horizons

GT New Horizons

867k Downloads

The Enchantress' Spell removes LP before checking if it can complete

EuropaSib opened this issue ยท 0 comments

commented

Your GTNH Discord Username

Syzygy

Your Pack Version

2.6.1

Your Server

private server

Java Version

Java 20

Type of Server

Don't know

Your Expectation

Trying to use the Enchantress' Spell ritual from blood magic for enchanting. I start with 3.9M LP in my network and activate the ritual. The ritual begins activating, says the ritual needs 3.2M LP and deducts that much from my LP network, leaving me with 700k LP left. I would expect that the ritual would then enchant my item, given it has already taken all the LP it requires from my network.

Before activating:
Image

After attempting to activate:
Image
Image

The Reality

The ritual fails, saying I do not have enough LP. If I let my network refill via Well of Suffering and come back later with over 3.2M LP in my network and try the ritual again, it succeeds without drawing any additional LP.

Your Proposal

I suspect the mod is checking if the ritual has enough LP to complete after already deducting the amount from my network, causing it to think I haven't got enough LP despite already having all it needs. The ritual should be checking the amount of LP it needs and whether it has enough before attempting to take anything from the network (other than perhaps the initial activation cost), such that if given all the LP it needs it will succeed regardless of how much LP my network has left.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.