MC  Eternal

MC Eternal

4M Downloads

[BUG] Pink Quark Candle not providing Matrix Enchantment boost

Tahnerd opened this issue · 4 comments

commented

Description of the Bug

While using the pink quark candle, tried to enchant over 40 pickaxes with Silk Touch. None of the picks ever had the tetris piece for Silk Touch. After testing a bit, at least some of the other candles seem to be working, so I believe this is an issue specific to certain candles. (As a note, I was able to tell the other candles were working, because the tetris piece says when the candle effected its occurance.)

Expected Behaviour

  1. Place Down Pink Quark Candle
  2. Add Tetris Pieces to Pickaxe
  3. Have an increased chance/general chance to add Silk Touch to the tool

Modpack Version

1.6.2 (Server) 1.6.2.3 (Client)

Screenshots

No response

Log

No response

Extra Info

Optifine v1.12.2

commented

This issue is very speculative, and nothing appears to be out of order with the config file's entry for silk touch.
and you were using the maximum 8 candles in MCE, yes? aswell as high enchanting power?
MCE is also configured to where Incompatible enchantments will never appear together in Matrix Enchanting, for example, a single Fortune piece existing prevents Silk Touch from generating, and vice versa, same with Smite, Bane of Arthropods, and Sharpness.

commented

I opened up MCE and did a little testing, and discovered that most Autosmelt enchantments, aswell as Smashing from CoFH Core, are classified as Incompatible with Silk Touch, stack that onto Silk's Very Rare rarity classification, and the odds for it to appear are poor thanks to Incompatible enchantments not showing up.

Not too sure what to do here, it's just one little enchantment, but i'd imagine one or two other things have a lesser variant of the issue.
allowing Incompatible enchantments again at a lower frequency seems like the most straightforward solution, but that's potentially bothersome for weapons, as they could roll a piece they have no intent to use, when everything else is already great.
Finalizing the enchantments only to disenchant the item is a general gameplay workaround that i imagined would be in use, though it might not cross many people's minds.

commented
commented

I had used 8 candles at first but after
looking at the quark config I had seen the maximum amount of candles that
could effect matrix enchanting was set to 4

This shouldn't be the case unless your configuration file for Quark in your MCE installation was deleted or corrupted, or you were looking at another modpack's config file, which would show the default values of max 4 Candles for influence, you can find the value here in the repository, and in a similar location in your download of the pack.

To help me properly review something like this before I bring it up to you,
how do you normally test for something like this from your end/how had you
identified the incompatability issue between enchantments?

I simply started up the game, gave it a few tests myself, and the possibility conflicting enchantments crossed my mind when i thought of how autosmelt and silk touch would work together, then i proceeded to test for that possibility using an Anvil, as it will refuse to apply incompatible enchantments to the same item.
It's hard to explain the complete thought process without making a monolith of text, and part of it can also just come naturally from having knowledge about the game.

To solve the issue w/o disabling any of the incompatable enchantment rules
since that seems to create its own set of issues, would raising the overall
chance that certain quark candles give enchants be a potential fix? From
what you mention, the Silk Touch should be available but it just has an
incredibly low chance to appear between the 4-5 more common enchants with
incompatability, so perhaps raising the candle benefits would help balance
it out

Quark's config isn't so extensive that individual Candles, much less Enchantments, can have the intensity of influence on them adjusted, it is a global value pulled for every single candle, and it's found just beneath the max candles value (see earlier link).
Bumping the influence rate in general isn't something i'm totally opposed to, considering how i've already tampered with the balance of the system a bit to try and make it appealing earlier on compared to possibly more pricey and more controllable modded means (such as crafting Enchantments with EnderIO's Enchanter), but i don't think that change alone would solve the problem, allowing incompatible enchantments to appear in the same matrix enchanting session would be a strict necessity to resolve this fully.