Nomifactory

Nomifactory

143k Downloads

Gregtech tools crash the game if you put it in the Ender IO Farmer

Hawkeye131 opened this issue ยท 19 comments

commented

crash-2019-07-07_10.46.00-client.txt

This took place when placing the Diamond Hoe from GregTech in to the Ender IO Farming station. The station was powered and had a Octadic RF Capacitor.

Please let me know if you need more info or more testing.

commented

Will be fixed by the GTCE update update, which is going to be... 1.3, maybe.

commented

same is true for slice and splice and probably any ender io machine

commented

it's apparently a gtce bug: see SleepyTrousers/EnderIO-1.5-1.12#5134

commented

I just got hit by this too. It's a fixed GTCE bug. Omnifactory is using an older version.

commented

It seems this issue is not actually fixed. GTCE just throws NullPointerException by Preconditions.checkNotNull.
Or I'm just missing something important. Can you check it out?
Relevant commit: GregTechCE/GregTech@b21b6ae#diff-90f42a9ce22c2960dc43ea4a5dc16bcf

commented

The precondition checks are to add a bit more contextual information to what would otherwise be just "NullPointerException in Foo.java:42". If the incoming data is unusable you can't really do anything about it besides throw an exception.

commented

Specifically, it makes no sense to be asked "hey, can you mine this block?" and then passing null for the block.

commented

From what @ALongStringOfNumbers tells me in Discord, Arch had implemented as a fix some sort of blacklist to prevent certain items from being used in certain machines in a more recent version of GTCE than we use currently.

We're planning to have GTCE updated to the latest version at worst by 1.3.

commented

I didn't notice that. Can you show me the commit?

commented

GregTechCE/GregTech@b7c6984 could potentially be it, as it prevents fake players from using certain tools to break blocks.

commented

Hmm, how do you actually fix this issue? I'm mentioning this because latest GTCE(gregtech-1.12.2-1.9.3.531) still crashes...

commented

Instead of trying to force the issue of using GT tools, you can just automate the crafting of vanilla tools and insert them into the farming station. There's no way around it crashing in the current version of OF unfortunately, and manually updating it will lead to disaster.

commented

Yeah, there's a reason we're still using a version of GTCE that's over a year old. The update requires a lot of tweaks to not break the pack scripts and restore the intended progression. If you wanted to try it out you'd probably want to build a client from #505 's feature branch and import it as a new instance/profile for testing (don't mess up your existing 1.2.2 instance).

commented

Okay I cloned the branch, put in MultiMC, built new instance, but it still crashes... Am I doing something wrong?

commented

Without a crash log it's tough to say either way. Regardless, the proposed fix from GTCE is supposed to block its tools from being allowed to be used by the EnderIO Farmer, not make them compatible with it.

Use non-GTCE tools.

commented

Ah, sorry. Here is crash log: log.txt
Then how about adding tooltip for clearfying that EIO Farmer cannot accept GT tools?

commented

See new GTCE issue here, as the crash is still present. GregTechCE/GregTech#1192

commented

Hah, was just about to say an issue should probably be reported.

In the meantime I wouldn't be opposed to putting a tooltip on the Farming Station to warn players of this incompatibility.

commented

Thanks!