Nomifactory

Nomifactory

143k Downloads

Uranium 233 (Nuclearcraft) doesn't produce correct fluid in fluid extractor.

Jimmy469 opened this issue ยท 5 comments

commented

Using Nuclearcraft's Uranium 233 (the only U-233 available, I think) in a fluid extractor produces ContentTweaker Uranium233 fluid, instead of Nuclearcraft Molten Uranium-233 (both recipes are registered, but only the latter has a use after melting down).

Plutonium-242 exhibits the same problem.

There's some other recipe weirdness going on with nuclearcraft, too. Tiny Clump of Uranium-235 (Nuclearcraft) have a 3x3 recipe to make both NC U-235 and GT U-235 ingots. On most crafting tables, it crafts GT U-235, but you can use a forestry workbench to pick and get NC U-235 if you'd rather.

For maximum weirdness,
Uranium-233 and Plutonium-242 melt into their CT versions, but only the NC version is useful.
Neptunium-246 melts into its CT version as well instead of the NC version (both are still registered), but in this case, only the CT version is useful, the NC one has no recipes...

Not quite sure what exactly the cause is, or how to fix. I'll probably look into it further as I work on omnium more.

commented

I fixed the issue (and #61) for myself by changing \config\nuclearcraft.cfg:1147 to false.

Annotated version of that part of the config, excuse my horrendous spelling here
# If enabled, recipes of the corresponding NC machine will also be added for GTCE machines. Order: Manufactory, Isotope Separator, Decay Hastener, Fuel Reprocessor, Alloy Furnace, Fluid Infuser, Melter, Supercooler, Electrolyzer, Neutron Irradiator, Ingot Former, Pressurizer, Chemical Reactor, Salt Mixer, Crystallizer, Fluid Enricher, Fluid Extractor, Centrifuge, Rock Crusher.
B:gtce_recipe_integration <
false Manuf
true Isotope Separator (adds the fuel->fuel parts recipes in thermal centrifuge)
true Decay hastener (I don't think there's a corresponding GTCE machine to add the recipes to)
true Fuel reprocessor (adds the spent fuel->new fuel bits recipes)
false Alloy Furnace
true Fluid Infuser (maybe adds the oxide fuels?)
true Melter (!!adds the duplicate, problematic fluid recipes)
true Supercooler (Adds a chemical bath supercooled ice recipe, perhaps more?)
false Electrolyzer
true Neutron Irradiator (don't know what this does in vanilla NC)
false Ingot former
false Pressurizer
false Chemical Reactor
true Salt mixer (probably adds the duplicate, although identical and harmless mixer recipe for energetic blend. a quick scroll through mixer recipes raised no red flags)
true Crystallizer (none of the NC crystals have recipes)
true Fluid Enricher (!!probably the over-eager fluxed electrum recipes)
false Fluid extractor
false Centrifuge
true Rock crusher (not about to scroll through 4314 macerator recipes to look for anything weird)
>

It's entirely possible that there are other nuclearcraft integration problems, and that they can be addressed in this config block as well. Will report if I find any.

commented

After some thought, I realized that the glass->quartz recipe is likely from nuclearcraft, since I didn't see it in the ct scripts and I think it showed up in 1.0.5. As far as I know, it represents the only renewable way to get quartz, which is needed in extreme quantities, so someone should check if disabling these NC recipes also disables that one, and perhaps add it back in.

commented

the problem isn't just for uranium, but also for every other fluid where you can make the stabilized version afterwards in the fluid solidifier. does this config change fix the other aswell?(curium, amaricium, berkelium etc) only plutonium works as it can be crafted to the ingot. they all require the ct recipe.

also what is the difference beetween line 1147, melter and 1157, fluid extractor?
the fluid extractor is already false!
so it just taht someone has forgotten that melter and fluid extractor is the same?

commented

The following fixes were based on these assumptions:

  1. Intended processing route is ALWAYS gregtech machines (exception of Fission Reactor to upgrade fuels to NC isotopes like Curium)
  2. You can extract multiple isotopes into one unified liquid, eg Plutonium 241 and 244 can be used to make Solidified Plutonium (only Uranium breaks this assumption currently).

Uranium

Uranium has GTCE (235/238) and NC isotopes and (233/235/238), and equivalent fluids. This is further complicated as GTCE and NC have different naming conventions, see below. First is GTCE, 2nd is NC for Uranium 235.
image

For Uranium 238 (first is GTCE, 2nd is NC):
image

Suggested Uranium Fix

  1. Change Melter GTCE Integration to false, as Jimmy suggested.
  2. Remove uranium 233 from contenttweaker, it's not needed as that fluid already exists in NuclearCraft.
    image
  3. Add a script that also lets NC molten Uranium-233 form into Stabilized Uranium after removing the CoT one.

Plutonium

Plutonium
A slightly problem comes up because there is a use for GTCE Plutonium 244 in GTCE Fusion Reactor, yet the only accessible Plutonium is the custom ContentTweaker one. However a player can just do turn the plutonium ingot into a plate and extract that instead as jank workaround. Overall it seems like Naquadah is better sourced from the microminers anyways, so maybe that Fusion reactor making use of GTCE Plutonium 244 should be removed.

Suggested Plutonium Fix
Plutonium Fix depends on developers intentions but based on above.

  1. Switch melter integration config to false (same as Uranium)
  2. Remove Plutonium 244/Thorium recipe in Fusion reactor to prevent future bug reports/confusion.

Fluid Plutonium 241 has no other uses, fluid NC Plutonium isotopes also has no other uses

**Americium / Neptunium / Curium/Berkelium/Californum **
Americium / Neptunium / Curium/Berkelium/Californum has no GTCE isotopes and their fluid counterparts have no GTCe specifc uses as well as no NC specific uses. Turning the melter config false should be fine since it will leave only GTCE Americium.

Disabling the melter recipes also disables the ores -> liquid in GTCE Fluid Extractor since those are part of NC's integration. This is another benefit for disabling the integration in fluid extractor.
image

@suisseWalter
Nuclearcraft Fluid Extractor has an item input, and an item output AND fluid output. They are not the same, it is designed to be closer to a canning machine or TE's Fluid Transposer and has a different set of CT methods.
image

Fluid Extractor being false means player's cannot empty coolers, but since coolers are cheap, I'm going to assume this is hardly a problem.

Renewable Nether Quartz was custom for the pack in a CT script, I used windows powershell to search the scripts and it appears to be on line 69 of Endgame.zs.

electrolyzer.recipeBuilder().inputs([<minecraft:glass> * 4]).outputs([<minecraft:quartz>]).duration(100).EUt(20).buildAndRegister();

Here is a map of the integrated machines between NC and GTCE, confirming on what Jimmy said, there is no equivalent to the decay hastener, so true/false on that doesn't matter.
https://github.com/turbodiesel4598/NuclearCraft/blob/01b092c46a112395a62f85836344f8780f99850f/src/main/java/nc/integration/gtce/GTCERecipeHelper.java#L36

commented

mostly fixed?