Nomifactory

Nomifactory

143k Downloads

[Bug] End Steel crafts wrong block version

Ar4093 opened this issue ยท 5 comments

commented

Pack Version:
latest-dev-preview (913e322)

Description:
The 3x3 recipe for an End Steel Block crafts the GT End Steel Block, which can't be used for example for the Solar Panel IV recipe.

Expected Behavior:
9 EnderIO End Steel Ingots should craft into an EnderIO End Steel Block.

Steps To Reproduce:
Put 9 ingots of End Steel into any crafting table. Observe the output.

commented

Thank you for bringing this to our attention. We're wondering how to best reproduce this error since we don't recall running into this during our testing.

Were you playing on another dev snapshot and recently updated to this version? If so, which snapshot were you playing on before?

There was a period of time where an ID shift was introduced (#499 -> #570) but later fixed by #578. The only new material we recall being introduced in the update was granite, which we were fairly sure did not affect our custom materials. We want to rule out this possibility and determine there is a new shift before proceeding with any changes.

commented

In the Worktable with 9 ingots, I can craft both:

  • Block of End Steel
  • End Steel Block
    In a normal crafting table, I can only craft the Block of End Steel (GT version)

This is a fresh instance from the latest dev release

commented

Worktables allow one to disambiguate a recipe's output if multiple recipes share the same inputs. This particular behavior is known and expected.

However, I was under the impression that in addition to being removed from the oreDict (to prevent JEI click-in from picking variants) for the shapeless recipes, the combining recipes for the undesired variants of these items were also removed.

We'll need to see if this is something we forgot to do or if Worktables are somehow retaining recipes we removed.

commented

Were you playing on another dev snapshot and recently updated to this version? If so, which snapshot were you playing on before?

This was on a fresh install.

I investigated into the oredict script (see #663), and the removal for End Steel actually removed a different block, with a metadata value one off.

commented

Yep, looking into it, there was an ID shift after the GTCE update PR was merged into the development branch, because GTCE added a new block (Block of Granite), which went into the end of the compressed list (at gregtech:compressed_16:12 specifically), which shifted everything beyond that up by one meta number, and also transmuting items stored in drawers based on the meta number shift (Note: Have only tried drawers, not AE) (Note 2: The compressed block range ended at compressed_18:1 before the PR, compressed_18:2 after the PR merge)

Not sure there is much we can do about the items shifting in the drawers, because that is completely on gtce's end that the block was added into the middle of the list. All we can do is adjust the scripts for anything that touched upon block compressed_16:12 and beyond.