Nomifactory

Nomifactory

143k Downloads

[Bug] Satchel quests

million09 opened this issue ยท 2 comments

commented

Pack Version:
dev@ 3939c19

Description:

  1. Basic Satchel quest (No.488) won't accept newly created one. Once the Satchel is used, the quest will be completed. (reported in #454)
  2. Satchel tasks for Hardened (No.544) / Reinforced (No.545) / Resonant (No.753) Satchel quests are satisfied by Basic Satchel. (reported in #25; Damien said this is fixed, but it seems still present)
  3. Signalum Satchel quest is missing. Or is this intentional?

Expected Behavior:

  1. Newly created Basic Satchel is accepted.
  2. Tasks for these quests are satisfied by each tier of Satchels.
  3. We have Signalum Satchel quest.

Steps To Reproduce:
0. Enable bq edit mode

1-1. Complete quest No.6 by command
1-2. Craft Basic Satchel
1-3. Make sure quest No.488 is not completed
1-4. Open the Satchel
1-5. Make sure quest No.488 is completed

  1. See that Satchel tasks for quest No.544 / 545 / 753 are already satisfied

  2. See that Signalum Satchel quest is not present in Satchel progression line

commented

We are somewhat aware of these issues already.

Because the basic satchel is detected as satisfying all tiers of satchel for the purposes of the quest, there is a workaround implemented where we require the nuggets from each satchel's recipe to be held to complete that quest, as it is unlikely that someone will make those for any other reason. This is probably the solution Damien is referencing in #25.

That the basic satchel is not triggering the first quest's completion is a more recent occurrence, as the quest was known to work at least as of 1.2.2. I'm not sure offhand if a Signalum tier of satchel exists in Thermal Expansion, but we can look into it.

commented

The reason why the basic satchel quest doesn't complete until you open the bag is because Thermal's default recipe for satchels does not create a bag with NBT tags on it, and opening the bag adds the "Accessible" tag that BQ expects on the item (as it appears in the quest item selector). Fixing that is a simple matter of letting this quest ignore NBT.

Quests triggering off the wrong types of satchel is a much more complicated problem. No manner of fiddling with the quest settings seems to prevent that. Even switching the type of quest from Retrieval to Crafting, it still considers all of the satchels to be the same item. This appears to be some kind of bug with BetterQuesting but I don't think there's any hope of it being fixed. The current workaround with other ingredients needing to be held will have to suffice.

The Signalum satchel not having a quest is an interesting oversight, but it's easy enough to solve by adding a quest for it.