Nomifactory

Nomifactory

143k Downloads

Wrong JEI recipe for small/tiny dusts

Midius opened this issue · 10 comments

commented

Pack Version:
Dev:0e6e1cd

Description:
When you import Dust from JEI into a 3x3 crafting grid the recipe for small dusts does not work. It imports it into the middle, which is still a recipe for tiny Dust. (Tested with different Dusts and they all work the same)

Expected Behavior:
It should Import/show the Dust in the bottom middle, which is the recipe for small Dust.
Unbenannt

commented

Hello, playing in 2024 this bug still exist

commented

This should have been adjusted with the merge of the latest GTCE/SoG update into the development pack in #746 so I am closing this issue.

commented

I don't think that we have much control over this, as it's a mod interaction between the recipes registered by GTCE and the fill capability from JEI.

I would suggest that this issue be brought up with GTCE. Perhaps something can be done about it there.

commented

I can explain some of this.

All 3 of these recipes reported in JEI are what is actually registered as recipes with Minecraft. The

  • Top left corner -> 9 tiny dust, and
  • Center -> 4 small dust

recipes are added by GTCE, where SoG adds the 3rd, top center -> 4 small dust recipe. All 3 of these recipes are registered as "2x2" recipes with Minecraft, meaning that MC will try to "expand" the recipe out when in a 3x3 crafting table. Unfortunately since these recipes cannot be shapeless, it is kind of essential to have them registered as 2x2, however the fact that SoG is adding a 3rd recipe is because of a failing recipe removal in that mod, of which is being looked into as part of the recipe rework work. If that were fixed, I believe this problem would be resolved.

commented

Yes, you can see the work being done on those recipes starting at line 637 in GARecipeAddition in that PR’s code changes

commented

Thank you for the explanation Dan, that makes sense. I believe you are referring to Shadows-of-Fire/Shadows-of-Greg#141 ?

commented

Hmm, yeah I see what you are talking about. I'm not actually sure why SoG is "fixing" the dust uncrafting recipes in the first place. I wonder if there was some point in time where GTCE recipes weren't working and SoG opted to fix it rather than create a pull request.

commented

A bit of context gleaned from discord conversations: GT5 has its dust recipes encoded such that small dusts are in the top-right of the 2x2 rather than GTCE's bottom-right slot. This is why both SoG and Gregicality are replacing the original recipe in the first place.

We believe that recipe precedence is also based on the order they are entered in the registry. Because the tiny piles are registered first, vanilla ends up expanding the tiny dusts 2x2 recipe in a 3x3 table out to:
(X being valid location and O being not)

XXO
XXO
OOO

And if I'm not mistaken, the small piles are valid at:

OOX
OOX
OXX

with the slots being a little wonky because the default GTCE bottom-right 2x2 recipe isn't actually getting removed properly in SoG at this time.

Dan and I have been hashing this out and we think we found a way to fix it. A PR to GTCE is forthcoming.

commented

Here is that PR: GregTechCE/GregTech#1596

commented

Thanks Dan, much appreciated.